Patch 1216: refactor patch index code a bit (and 1 more) - Darcs bug tracker

Title	refactor patch index code a bit (and 1 more)
Superseder		Nosy List	ganesh, gh
Related Issues
Status	obsoleted	Assigned To
Milestone

Created on 2014-11-13.07:53:25 by ganesh, last changed 2014-11-15.21:30:51 by gh.

Files
File name	Status	Uploaded	Type	Edit	Remove
patch-preview.txt		ganesh, 2014-11-13.07:53:24	text/x-darcs-patch
patch-preview.txt		ganesh, 2014-11-13.18:21:22	text/x-darcs-patch
refactor-patch-index-code-a-bit.dpatch		ganesh, 2014-11-13.07:53:24	application/x-darcs-patch
refactor-patch-index-code-a-bit.dpatch		ganesh, 2014-11-13.18:21:22	application/x-darcs-patch
unnamed		ganesh, 2014-11-13.07:53:24
unnamed		ganesh, 2014-11-13.18:21:22

See mailing list archives for discussion on individual patches.

Messages
msg17779 (view)	Author: ganesh	Date: 2014-11-13.07:53:24
Just for discussion/experimentation for now. Guillaume mentioned on IRC that darcs might be holding all the patches in memory when building a patch index from scratch. This change ought to make it more incremental as PatchSet is the standard structure for reading a repository lazily, but in practice I don't see much difference in memory usage with +RTS -s 2 patches for repository darcs-unstable@darcs.net:screened: Thu Nov 13 07:26:27 GMT 2014 Ganesh Sittampalam <ganesh@earth.li> * refactor patch index code a bit - generalise return type of patches2patchMods to make it easier to call incrementally - abstract out patchSet2patchMods in preparation for a more efficient implementation Thu Nov 13 07:40:15 GMT 2014 Ganesh Sittampalam <ganesh@earth.li> * try to build patch index incrementally Attachments patch-preview.txt refactor-patch-index-code-a-bit.dpatch unnamed
msg17780 (view)	Author: gh	Date: 2014-11-13.17:34:17
I'm having the following error on darcs.net with your patches: $ darcs optimize enable-patch-index +RTS -prof darcs: error: patch index entry for file ./Repository.lhs created >1 times
msg17781 (view)	Author: ganesh	Date: 2014-11-13.18:21:22
Apologies, I forgot to actually run the locally built darcs when I was testing this :-) Still doesn't seem any faster/less memory hungry in practice though. 2 patches for repository darcs-unstable@darcs.net:screened: Thu Nov 13 07:26:27 GMT 2014 Ganesh Sittampalam <ganesh@earth.li> * refactor patch index code a bit - generalise return type of patches2patchMods to make it easier to call incrementally - abstract out patchSet2patchMods in preparation for a more efficient implementation Thu Nov 13 18:18:11 GMT 2014 Ganesh Sittampalam <ganesh@earth.li> * try to build patch index incrementally Attachments patch-preview.txt refactor-patch-index-code-a-bit.dpatch unnamed

History
Date	User	Action	Args
2014-11-13 07:53:25	ganesh	create
2014-11-13 07:53:33	ganesh	set	status: needs-screening -> in-discussion
2014-11-13 07:53:46	ganesh	set	nosy: + gh
2014-11-13 17:34:17	gh	set	messages: + msg17780
2014-11-13 18:21:22	ganesh	set	files: + patch-preview.txt, refactor-patch-index-code-a-bit.dpatch, unnamed messages: + msg17781
2014-11-15 21:30:51	gh	set	status: in-discussion -> obsoleted