darcs

Patch 1218 move Iso and IsoFunctor from Darcs.UI.Options.Core to ...

Title move Iso and IsoFunctor from Darcs.UI.Options.Core to ...
Superseder Nosy List bfrk
Related Issues
Status accepted Assigned To
Milestone

Created on 2014-11-13.23:57:54 by bfrk, last changed 2015-02-12.18:29:58 by gh.

Files
File name Status Uploaded Type Edit Remove
move-iso-and-isofunctor-from-darcs_ui_options_core-to-darcs_ui_options_iso.dpatch bfrk, 2014-11-13.23:57:54 application/x-darcs-patch
patch-preview.txt bfrk, 2014-11-13.23:57:54 text/x-darcs-patch
unnamed bfrk, 2014-11-13.23:57:54
See mailing list archives for discussion on individual patches.
Messages
msg17786 (view) Author: bfrk Date: 2014-11-13.23:57:54
A small re-factoring that I needed when playing with converting Options.Core
to a deep embedding. I think the separation is a good idea.

1 patch for repository http://darcs.net/screened:

patch ad2a1363bddbd799b48ef552c5f055009a8a27d7
Author: Ben Franksen <benjamin.franksen@helmholtz-berlin.de>
Date:   Thu Nov 13 02:46:19 CET 2014
  * move Iso and IsoFunctor from Darcs.UI.Options.Core to Darcs.UI.Options.Iso
Attachments
msg17787 (view) Author: bfrk Date: 2014-11-14.00:05:36
This patch was signed, so it should automatically be pushed to screened.
Let's see...
msg17791 (view) Author: bfrk Date: 2014-11-14.01:08:27
How long does it normally take for the patch to be auto-pushed to screened?
msg17797 (view) Author: bfrk Date: 2014-11-14.15:18:12
Ok, signing the patch seems not to work for me. Does the patch tracker
do any extra checks like comparing patch author, mail address and
signature meta-data?

For the meantime, I'll push manually.
msg17910 (view) Author: gh Date: 2014-12-15.18:09:49
Looks correct but.. is this useful for something?
msg17918 (view) Author: bfrk Date: 2014-12-29.14:37:08
The Iso stuff is used in many places in the Options subsystem to lift
data type conversions to the option level. There are other ways to do
this but I found that this light-weight approach reduces the boilerplate
to the minimum. For a simple example, look at the definition of
Darcs.UI.Options.All.dryRun where the Iso is between Bool and
Darcs.Repository.Flags.DryRun.
msg17967 (view) Author: bfrk Date: 2015-01-31.18:39:00
This is a straight forward cleanup patch, self-accept.
msg18101 (view) Author: gh Date: 2015-02-12.18:29:58
We need it in branch 2.10 as dependency of a bugfix.
History
Date User Action Args
2014-11-13 23:57:54bfrkcreate
2014-11-14 00:00:01bfrksetstatus: needs-screening -> needs-review
2014-11-14 00:05:36bfrksetmessages: + msg17787
2014-11-14 01:08:27bfrksetmessages: + msg17791
2014-11-14 15:18:13bfrksetmessages: + msg17797
2014-12-15 18:09:49ghsetmessages: + msg17910
2014-12-29 14:37:08bfrksetmessages: + msg17918
2015-01-31 18:39:01bfrksetstatus: needs-review -> accepted
messages: + msg17967
2015-02-12 18:29:58ghsetmessages: + msg18101