darcs

Patch 1229 resolve issue2414: use parseFlags instead of toMatchFl...

Title resolve issue2414: use parseFlags instead of toMatchFl...
Superseder Nosy List gh
Related Issues
Status accepted Assigned To
Milestone

Created on 2014-11-17.20:42:59 by gh, last changed 2015-02-12.18:17:07 by gh.

Files
File name Status Uploaded Type Edit Remove
patch-preview.txt gh, 2014-11-17.20:42:58 text/x-darcs-patch
patch-preview.txt gh, 2014-11-17.20:57:27 text/x-darcs-patch
resolve-issue2414_-use-parseflags-instead-of-tomatchflags-where-needed.dpatch gh, 2014-11-17.20:42:58 application/x-darcs-patch
resolve-issue2414_-use-parseflags-instead-of-tomatchflags-where-needed.dpatch gh, 2014-11-17.20:57:27 application/x-darcs-patch
unnamed gh, 2014-11-17.20:42:58
unnamed gh, 2014-11-17.20:57:27
See mailing list archives for discussion on individual patches.
Messages
msg17832 (view) Author: gh Date: 2014-11-17.20:42:58
A consequence of the new option parsing system.
This fixes the non-working -h / --hash flag for many commands.

1 patch for repository http://darcs.net:

patch 202164996ca8855048c73ae9f79d3f59443646d4
Author: Guillaume Hoffmann <guillaumh@gmail.com>
Date:   Mon Nov 17 17:41:11 ART 2014
  * resolve issue2414: use parseFlags instead of toMatchFlags where needed
Attachments
msg17833 (view) Author: gh Date: 2014-11-17.20:57:27
Removing a couple of hunks to fix tests for clone and rebase unsuspend.


1 patch for repository http://darcs.net:

patch 3ae568c35f99a0ea558f979c30a2cfcf2c51f1c8
Author: Guillaume Hoffmann <guillaumh@gmail.com>
Date:   Mon Nov 17 17:50:32 ART 2014
  * resolve issue2414: use parseFlags instead of toMatchFlags where needed
Attachments
msg17835 (view) Author: bfrk Date: 2014-11-17.21:58:35
Cool. I have a very similar patch lying around here. It would be nice if
we could eliminate the rest of the toMatchFlag ocurrences, too. This is
what I tried but I got some new test failures, probably because of that.
See Ganesh's comments about --to-patch being interpreted as OnePatch or
as UpToPatch depending on the command.
msg17914 (view) Author: gh Date: 2014-12-15.18:45:25
Self-accept.
msg18097 (view) Author: gh Date: 2015-02-12.18:17:07
Goes into 2.10 as bugfix.
History
Date User Action Args
2014-11-17 20:42:59ghcreate
2014-11-17 20:57:27ghsetfiles: + patch-preview.txt, resolve-issue2414_-use-parseflags-instead-of-tomatchflags-where-needed.dpatch, unnamed
messages: + msg17833
2014-11-17 20:59:03ghsetstatus: needs-screening -> needs-review
2014-11-17 21:58:35bfrksetmessages: + msg17835
2014-12-15 18:45:25ghsetstatus: needs-review -> accepted
messages: + msg17914
2015-02-12 18:17:07ghsetmessages: + msg18097