darcs

Patch 1230 Uncouple the --mail and --sendmail-command options

Title Uncouple the --mail and --sendmail-command options
Superseder Nosy List ganesh
Related Issues
Status accepted Assigned To
Milestone 2.10.0

Created on 2014-11-17.21:08:46 by ganesh, last changed 2015-02-12.18:33:04 by gh.

Files
File name Status Uploaded Type Edit Remove
patch-preview.txt ganesh, 2014-11-17.21:08:46 text/x-darcs-patch
uncouple-the-__mail-and-__sendmail_command-options.dpatch ganesh, 2014-11-17.21:08:46 application/x-darcs-patch
unnamed ganesh, 2014-11-17.21:08:46
See mailing list archives for discussion on individual patches.
Messages
msg17834 (view) Author: ganesh Date: 2014-11-17.21:08:46
Ben, let me know if you object to this. I'll leave it in-discussion
for a bit but my own inclination is to make this change for now.

1 patch for repository darcs-unstable@darcs.net:screened:

Mon Nov 17 21:03:57 GMT 2014  Ganesh Sittampalam <ganesh@earth.li>
  * Uncouple the --mail and --sendmail-command options
  
  They were coupled together in the options rewrite, but it
  seems that some of the tests actually call --sendmail-command
  without --mail. This may be a hangover from the issue2204 changes,
  or it might be deliberate and I'm having trouble working out how
  things *should* behave.
  
  So for now I think it's best to go back to having them be
  independent options, and figure this out properly separately.
Attachments
msg17839 (view) Author: bfrk Date: 2014-11-17.22:33:28
Please go ahead. As you said, we can sort this out later.

I originally tried to couple as many flags as I could into a single
(combined) option, so as to save on new types I'd have to add. And I was
never completely happy with the solution for the mail option I arrived at.
msg17987 (view) Author: bfrk Date: 2015-02-02.22:56:10
We should keep it like it is for now, with the independent switches. It
works and isn't that ugly.
msg18102 (view) Author: gh Date: 2015-02-12.18:33:04
Goes into branch 2.10.
History
Date User Action Args
2014-11-17 21:08:46ganeshcreate
2014-11-17 21:09:19ganeshsetstatus: needs-screening -> in-discussion
2014-11-17 22:33:28bfrksetmessages: + msg17839
2014-11-18 06:34:28ganeshsetstatus: in-discussion -> needs-screening
2014-11-18 06:51:43ganeshsetstatus: needs-screening -> needs-review
2015-02-02 22:56:10bfrksetstatus: needs-review -> accepted
messages: + msg17987
milestone: 2.10.0
2015-02-12 18:33:04ghsetmessages: + msg18102