darcs

Patch 1233 fix the --to-patch and --to-match flags

Title fix the --to-patch and --to-match flags
Superseder Nosy List ganesh
Related Issues
Status accepted Assigned To
Milestone 2.10.0

Created on 2014-11-19.07:09:50 by ganesh, last changed 2015-02-12.18:36:37 by gh.

Files
File name Status Uploaded Type Edit Remove
fix-the-__to_patch-and-__to_match-flags.dpatch ganesh, 2014-11-19.07:09:49 application/x-darcs-patch
patch-preview.txt ganesh, 2014-11-19.07:09:49 text/x-darcs-patch
unnamed ganesh, 2014-11-19.07:09:49
See mailing list archives for discussion on individual patches.
Messages
msg17845 (view) Author: ganesh Date: 2014-11-19.07:09:49
The simplest possible hack to fix the --to-patch and --to-match
flags (patch1226 has some history of the problem).

I did briefly consider updating the code that's called to
use a better representation of the match flags, but decided
that would be too much effort/have too much collateral impact.

1 patch for repository darcs-unstable@darcs.net:screened:

Wed Nov 19 06:48:24 GMT 2014  Ganesh Sittampalam <ganesh@earth.li>
  * fix the --to-patch and --to-match flags
  
  Before the options rewrite, clone used to treat these flags
  as if they were --patch and --match, and other commands treated
  them normally. In the rewrite, the clone behaviour accidentally
  got extended to the other commands.
  
  This fixes them to behave as expected, and explicitly translates
  them in the case of clone.
Attachments
msg18103 (view) Author: gh Date: 2015-02-12.18:36:37
I'm not a 100% confident about the whole flag system refactoring, but
this patch does what it description says and it has been here for a
while, so I'll accept it (also goes into 2.10 as it is a bugfix).
History
Date User Action Args
2014-11-19 07:09:50ganeshcreate
2014-11-19 07:14:23ganeshsetstatus: needs-screening -> needs-review
2015-02-05 12:21:44bfrksetstatus: needs-review -> accepted
milestone: 2.10.0
2015-02-12 18:36:37ghsetmessages: + msg18103