darcs

Patch 1239 WIP: sort out encoding of output

Title WIP: sort out encoding of output
Superseder Nosy List ganesh
Related Issues Check displaying of Unicode patch metadata
View: 1693
Status accepted Assigned To
Milestone 2.10.0

Created on 2014-12-08.19:10:12 by ganesh, last changed 2015-02-12.19:05:36 by gh. Tracked on DarcsWatch.

Files
File name Status Uploaded Type Edit Remove
make-more-of-an-effort-to-encode-output-correctly.dpatch ganesh, 2014-12-31.20:24:04 application/x-darcs-patch
patch-preview.txt ganesh, 2014-12-08.19:10:11 text/x-darcs-patch
patch-preview.txt ganesh, 2014-12-31.20:24:04 text/x-darcs-patch
rolled-back-some-accidental-changes-to-messages-and-comments.dpatch bfrk, 2015-01-08.17:37:09 application/x-darcs-patch
unnamed ganesh, 2014-12-08.19:10:11
unnamed ganesh, 2014-12-31.20:24:04
wip_-sort-out-encoding-of-output.dpatch dead ganesh, 2014-12-08.19:10:11 application/x-darcs-patch
See mailing list archives for discussion on individual patches.
Messages
msg17883 (view) Author: ganesh Date: 2014-12-08.19:10:11
Obviously just for discussion for now given the patch name.

This is a rather hacky attempt to fix issue1693 - unfortunately
I can't come up with anything better, at least for 2.10. I'll
add some discussion of the issues there.

1 patch for repository darcs-unstable@darcs.net:screened:

Mon Dec  8 07:15:18 GMT 2014  Ganesh Sittampalam <ganesh@earth.li>
  * WIP: sort out encoding of output
Attachments
msg17923 (view) Author: bfrk Date: 2014-12-30.14:54:01
I get conflicts when I apply this to an up-to-date clone of screened.
Could you rebase it for easier review?
msg17925 (view) Author: ganesh Date: 2014-12-31.20:24:04
Here's an amended version that should apply cleanly to screened.

I'll give a few days for any final shouts of horror then will
screen it.

1 patch for repository darcs-unstable@darcs.net:screened:

Wed Dec 31 20:11:38 GMT 2014  Ganesh Sittampalam <ganesh@earth.li>
  * Make more of an effort to encode output correctly
  
  Add a new parameter to control how to encode output. This is
  really just a sticking plaster on top of an existing mess.
  
  See issue1693 for more discussion of this.
Attachments
msg17927 (view) Author: bfrk Date: 2015-01-08.17:37:09
The patch contains a few changes that were probably not meant to be in
there. I have attached a patch that rolls them back. Please review
before screening.
Attachments
msg17928 (view) Author: ganesh Date: 2015-01-08.20:53:15
Oops. Thanks for the correction, I've screened it.
msg17929 (view) Author: darcswatch Date: 2015-01-08.21:05:41
This patch bundle (with 1 patches) was just applied to the repository http://darcs.net/screened.
This message was brought to you by DarcsWatch
http://darcswatch.nomeata.de/repo_http:__darcs.net_screened.html#bundle-cd09d6d3af025c8f63652aa84bfb249ebcd678b2
msg18015 (view) Author: bfrk Date: 2015-02-05.14:45:27
I will accept the version that is in screened because

(1) it makes more transparent when we encode the data and when not,
    which is a good thing, and it forces us to think about when to
    encode and when not
(2) it allows us to quickly and more easily fix things
(3) many patches in screened already depend on it

For the long(er) run, i.e. past 2.10, see the comment I added to issue1693.
msg18018 (view) Author: darcswatch Date: 2015-02-05.15:05:30
This patch bundle (with 1 patches) was just applied to the repository http://darcs.net/reviewed.
This message was brought to you by DarcsWatch
http://darcswatch.nomeata.de/repo_http:__darcs.net_reviewed.html#bundle-cd09d6d3af025c8f63652aa84bfb249ebcd678b2
msg18111 (view) Author: gh Date: 2015-02-12.19:05:36
And it goes into branch 2.10 as dependency of bundle compression optimization.
History
Date User Action Args
2014-12-08 19:10:12ganeshcreate
2014-12-08 19:10:51ganeshsetstatus: needs-screening -> in-discussion
2014-12-08 19:14:59ganeshsetissues: + Check displaying of Unicode patch metadata
2014-12-30 14:54:01bfrksetmessages: + msg17923
2014-12-31 20:24:04ganeshsetfiles: + patch-preview.txt, make-more-of-an-effort-to-encode-output-correctly.dpatch, unnamed
messages: + msg17925
2015-01-06 19:06:08ganeshsetstatus: in-discussion -> needs-screening
2015-01-06 19:14:27ganeshsetstatus: needs-screening -> needs-review
2015-01-08 17:37:09bfrksetfiles: + rolled-back-some-accidental-changes-to-messages-and-comments.dpatch
messages: + msg17927
2015-01-08 17:37:53darcswatchsetdarcswatchurl: http://darcswatch.nomeata.de/repo_http:__darcs.net_reviewed.html#bundle-cd09d6d3af025c8f63652aa84bfb249ebcd678b2
2015-01-08 20:53:16ganeshsetmessages: + msg17928
2015-01-08 21:05:42darcswatchsetmessages: + msg17929
2015-02-05 14:45:27bfrksetstatus: needs-review -> accepted
messages: + msg18015
milestone: 2.10.0
2015-02-05 15:05:30darcswatchsetmessages: + msg18018
2015-02-12 19:05:36ghsetmessages: + msg18111