darcs

Patch 1250 cleanup: group type signatures with defi... (and 2 more)

Title cleanup: group type signatures with defi... (and 2 more)
Superseder Nosy List bfrk
Related Issues
Status accepted Assigned To
Milestone 2.10.0

Created on 2015-01-26.15:58:24 by bfrk, last changed 2015-03-04.00:29:08 by gh.

Files
File name Status Uploaded Type Edit Remove
cleanup_-group-type-signatures-with-definitions-_withlock_releaselock_.dpatch bfrk, 2015-01-26.15:58:23 application/x-darcs-patch
patch-preview.txt bfrk, 2015-01-26.15:58:23 text/x-darcs-patch
unnamed bfrk, 2015-01-26.15:58:23
See mailing list archives for discussion on individual patches.
Messages
msg17957 (view) Author: bfrk Date: 2015-01-26.15:58:23
The first two are trivial and obviously correct. The third is a bit more
involved, but I am fairly certain it does not change the external behavior.

3 patches for repository http://darcs.net/screened:

patch 35888e87b87086f8255856fbf404a6ba67108560
Author: Ben Franksen <benjamin.franksen@helmholtz-berlin.de>
Date:   Sat Jan 24 23:30:31 CET 2015
  * cleanup: group type signatures with definitions (withLock,releaseLock)

patch 89587e5c485854f4b4eca97645f4bafcb3a1426f
Author: Ben Franksen <benjamin.franksen@helmholtz-berlin.de>
Date:   Sat Jan 24 23:33:33 CET 2015
  * cleanup: fixed indentation of convert command definitions

patch e27421a2dcf2711ef2f4cbcad61f0b28d235d3de
Author: Ben Franksen <benjamin.franksen@helmholtz-berlin.de>
Date:   Sat Jan 24 23:45:39 CET 2015
  * cleanup: removed flag membership tests (marks, patchIndex, lazy)
  
  In Darcs.Repository, cloneRepository and createRepository now take
  PatchIndexOption instead of Bool as argument for whether to create or delete
  the patch index. Overriding this option with NoPatchIndex for lazy clones
  has been moved from Darcs.UI.Commands.Clone to cloneRepository.
Attachments
msg18017 (view) Author: bfrk Date: 2015-02-05.14:56:10
Straight forward cleanups, self-accept.
msg18250 (view) Author: gh Date: 2015-03-04.00:29:08
Trivial, accepted into branch 2.10.
History
Date User Action Args
2015-01-26 15:58:24bfrkcreate
2015-01-26 17:34:28bfrksetstatus: needs-screening -> needs-review
2015-02-05 14:56:11bfrksetstatus: needs-review -> accepted
messages: + msg18017
milestone: 2.10.0
2015-03-04 00:29:08ghsetmessages: + msg18250