Patch 1262: cleanup: slightly streamlined doRecord (and 2 more) - Darcs bug tracker

Title	cleanup: slightly streamlined doRecord (and 2 more)
Superseder		Nosy List	bfrk
Related Issues
Status	obsoleted	Assigned To
Milestone

Created on 2015-02-07.14:45:05 by bfrk, last changed 2015-02-11.00:00:38 by bfrk.

Files
File name	Status	Uploaded	Type	Edit	Remove
cleanup_-slightly-streamlined-dorecord.dpatch		bfrk, 2015-02-07.14:45:04	application/x-darcs-patch
patch-preview.txt		bfrk, 2015-02-07.14:45:04	text/x-darcs-patch
unnamed		bfrk, 2015-02-07.14:45:04

See mailing list archives for discussion on individual patches.

Messages
msg18044 (view)	Author: bfrk	Date: 2015-02-07.14:45:04
These came up in my (as yet unsuccessful) attempts to resolve issue1327. The last one should be carefully reviewed; I am not sure I know what I am doing here (but it seems to work for me). 3 patches for repository http://darcs.net/screened: patch 1259707ab05dadf6c7c82eddd91f83a96e5b13f1 Author: Ben Franksen <benjamin.franksen@helmholtz-berlin.de> Date: Sat Feb 7 14:01:45 CET 2015 * cleanup: slightly streamlined doRecord patch 4b50fd374b31c32d6481ced38fc2d480936ed8ef Author: Ben Franksen <benjamin.franksen@helmholtz-berlin.de> Date: Sat Feb 7 14:29:49 CET 2015 * cleanup: tentativelyReplacePatches is only used internally patch 94ce414ef9af423b77da1e6f4fbe8d434f3091b4 Author: Ben Franksen <benjamin.franksen@helmholtz-berlin.de> Date: Sat Feb 7 14:37:23 CET 2015 * simplified HashedRepo.removeFromTentativeInventory The change follows the outline indicated in the FIXME comment: we let writeTentativeInventory do the heavy lifting. Also clearly documented the preconditions, since this is a partial function. With this change, Darcs.Patch.Depends.commuteToEnd is no longert needed and has been removed. Attachments cleanup_-slightly-streamlined-dorecord.dpatch patch-preview.txt unnamed
msg18068 (view)	Author: bfrk	Date: 2015-02-11.00:00:38
Split up into patch1270 and patch1269.

History
Date	User	Action	Args
2015-02-07 14:45:05	bfrk	create
2015-02-10 23:56:44	bfrk	set	status: needs-screening -> needs-review
2015-02-11 00:00:38	bfrk	set	status: needs-review -> obsoleted messages: + msg18068