darcs

Patch 1275 added debugDocLn to Darcs.Util.Printer (and 1 more)

Title added debugDocLn to Darcs.Util.Printer (and 1 more)
Superseder Nosy List bfrk
Related Issues
Status accepted Assigned To
Milestone

Created on 2015-02-11.00:29:01 by bfrk, last changed 2015-06-09.06:10:10 by ganesh.

Files
File name Status Uploaded Type Edit Remove
added-debugdocln-to-darcs_util_printer.dpatch bfrk, 2015-02-11.00:29:00 application/x-darcs-patch
patch-preview.txt bfrk, 2015-02-11.00:29:00 text/x-darcs-patch
unnamed bfrk, 2015-02-11.00:29:00
See mailing list archives for discussion on individual patches.
Messages
msg18073 (view) Author: bfrk Date: 2015-02-11.00:29:00
Minor additions to ease debugging. The first one is there so we can easily
print things like patch info or summary if --debug was given.

The second one is of obvious use (the need for profiling to be enabled is a
bit unfortunate). In case you wonder: yes, getting a stack trace is
available in ghc-7.4.1.

2 patches for repository http://darcs.net/screened:

patch c6cc3ff63b73909cd9cc85a300ab9856b389c2b2
Author: Ben Franksen <benjamin.franksen@helmholtz-berlin.de>
Date:   Wed Feb 11 01:08:48 CET 2015
  * added debugDocLn to Darcs.Util.Printer

patch ef32279fc7834282117053f01712bc07459da75f
Author: Ben Franksen <benjamin.franksen@helmholtz-berlin.de>
Date:   Wed Feb 11 01:12:02 CET 2015
  * errorDoc now prints a stack trace (if profiling was enabled)
Attachments
msg18144 (view) Author: gh Date: 2015-02-17.22:52:13
I see another 'errorDoc' function in src/Darcs/Util/Printer/Color.hs.
Does it also need to be modified?
msg18146 (view) Author: bfrk Date: 2015-02-18.01:21:55
I only looked at Darcs.Util.Bug and what it imports. Yes, assertDoc
could be adapted in the same way. I have a patch but I would like to
factor out the unsafe/GHC stuff. Then I thought shouldn't both errorDoc
functions rather be in Darcs.Util.Bug instead of the Printer modules?
History
Date User Action Args
2015-02-11 00:29:01bfrkcreate
2015-02-11 00:29:38bfrksetstatus: needs-screening -> needs-review
2015-02-17 22:52:14ghsetmessages: + msg18144
2015-02-18 01:21:55bfrksetmessages: + msg18146
2015-06-09 05:35:03ganeshsetstatus: needs-review -> accepted-pending-tests
2015-06-09 06:10:10ganeshsetstatus: accepted-pending-tests -> accepted