Patch 1286: fixed failing fromJust in look-for-replaces implementa... - Darcs bug tracker

Title	fixed failing fromJust in look-for-replaces implementa...
Superseder	fixed failing fromJust in look-for-replaces implementa... View: 1292	Nosy List	bfrk
Related Issues
Status	obsoleted	Assigned To
Milestone

Created on 2015-02-19.02:37:10 by bfrk, last changed 2015-02-19.23:15:59 by bfrk.

Files
File name	Status	Uploaded	Type	Edit	Remove
fixed-failing-fromjust-in-look_for_replaces-implementation.dpatch		bfrk, 2015-02-19.02:37:10	application/x-darcs-patch
patch-preview.txt		bfrk, 2015-02-19.02:37:10	text/x-darcs-patch
unnamed		bfrk, 2015-02-19.02:37:10

See mailing list archives for discussion on individual patches.

Messages
msg18164 (view)	Author: bfrk	Date: 2015-02-19.02:37:10
1 patch for repository http://darcs.net/reviewed: patch 92b6f93089ebfcfc8b61649f775708fd378a4a76 Author: Ben Franksen <benjamin.franksen@helmholtz-berlin.de> Date: Thu Feb 19 03:35:29 CET 2015 * fixed failing fromJust in look-for-replaces implementation As indicated in a comment in the code, this is not a good solution because we traverse the tree twice. At least it no longer crashes now. Attachments fixed-failing-fromjust-in-look_for_replaces-implementation.dpatch patch-preview.txt unnamed
msg18175 (view)	Author: bfrk	Date: 2015-02-19.23:00:36
BTW, I see similar (fromJust) problems lurking inside Darcs.UI.Commands.Replace.

History
Date	User	Action	Args
2015-02-19 02:37:10	bfrk	create
2015-02-19 23:00:36	bfrk	set	messages: + msg18175
2015-02-19 23:15:59	bfrk	set	status: needs-screening -> obsoleted superseder: + fixed failing fromJust in look-for-replaces implementa...