darcs

Patch 1290 cleanup: import anchoredRoot instead of ... (and 4 more)

Title cleanup: import anchoredRoot instead of ... (and 4 more)
Superseder Nosy List bfrk
Related Issues
Status accepted Assigned To
Milestone 2.10.0

Created on 2015-02-19.22:49:09 by bfrk, last changed 2015-02-26.18:57:52 by gh.

Files
File name Status Uploaded Type Edit Remove
cleanup_-import-anchoredroot-instead-of-internal-representation.dpatch bfrk, 2015-02-19.22:49:09 application/x-darcs-patch
patch-preview.txt bfrk, 2015-02-19.22:49:09 text/x-darcs-patch
unnamed bfrk, 2015-02-19.22:49:09
See mailing list archives for discussion on individual patches.
Messages
msg18173 (view) Author: bfrk Date: 2015-02-19.22:49:09
These are all more or less trivial cleanups. Will self-screen but there's no
need to have them in 2.10.

5 patches for repository http://darcs.net/screened:

patch 173f7e6edee02e30da28748bcfb2ea42da3c07ca
Author: Ben Franksen <benjamin.franksen@helmholtz-berlin.de>
Date:   Fri Feb 13 21:30:17 CET 2015
  * cleanup: import anchoredRoot instead of internal representation

patch 0fca606770e93b3502026ea3512900112674c61c
Author: Ben Franksen <benjamin.franksen@helmholtz-berlin.de>
Date:   Sat Feb 14 02:55:22 CET 2015
  * fixed type of identifyRepositoryFor according to TODO in comment

patch e76075aeacf09a0b6620c58b2e902cf6b2a2f7b0
Author: Ben Franksen <benjamin.franksen@helmholtz-berlin.de>
Date:   Sat Feb 14 02:56:31 CET 2015
  * cleanup: Repository.Format and .Internal haddocks and variable names
  
  Also rename readfromAndWritetoProblem to transferProblem.

patch 844ca3dd6bd9dff2cf9bba7513983b5c04ecc0b2
Author: Ben Franksen <benjamin.franksen@helmholtz-berlin.de>
Date:   Sat Feb 14 15:00:54 CET 2015
  * cleanup: renamed PatchIndexOption to WithPatchIndex

patch 84e70b846b7757752e7500d486521cb7e5dfedbb
Author: Ben Franksen <benjamin.franksen@helmholtz-berlin.de>
Date:   Sat Feb 14 15:01:14 CET 2015
  * cleanup: renamed applyas to applyAs
Attachments
msg18231 (view) Author: gh Date: 2015-02-26.18:57:52
Accepted into branch 2.10 since a bugfix depends on them.

* cleanup: import anchoredRoot: OK
* fixed type of identifyRepositoryFor: OK, good to see that the change
doesn't break compilation
* cleanup: Repository.Format and .Internal: OK, nice changes to make the
code more understandable + haddocks
* cleanup: renamed PatchIndexOption to WithPatchIndex: OK
* cleanup: renamed applyas to applyAs: OK
History
Date User Action Args
2015-02-19 22:49:09bfrkcreate
2015-02-19 22:50:01bfrksetstatus: needs-screening -> needs-review
2015-02-26 18:57:52ghsetstatus: needs-review -> accepted
messages: + msg18231
milestone: 2.10.0