darcs

Patch 1296 resolve issue2431: rollback Control.Monad.Catch genera...

Title resolve issue2431: rollback Control.Monad.Catch genera...
Superseder Nosy List bfrk
Related Issues
Status accepted Assigned To
Milestone 2.10.0

Created on 2015-02-21.20:49:37 by bfrk, last changed 2015-02-27.02:36:08 by bfrk.

Files
File name Status Uploaded Type Edit Remove
patch-preview.txt bfrk, 2015-02-21.20:49:37 text/x-darcs-patch
resolve-issue2431_-rollback-control_monad_catch-generalizations.dpatch bfrk, 2015-02-21.20:49:37 application/x-darcs-patch
unnamed bfrk, 2015-02-21.20:49:37
See mailing list archives for discussion on individual patches.
Messages
msg18202 (view) Author: bfrk Date: 2015-02-21.20:49:37
1 patch for repository http://darcs.net/screened:

patch 3f4d72036e7939c3749c6d32b07188837eadc63a
Author: Ben Franksen <benjamin.franksen@helmholtz-berlin.de>
Date:   Sat Feb 21 21:42:07 CET 2015
  * resolve issue2431: rollback Control.Monad.Catch generalizations
  
  I even went so far as to remove the exceptions package from the cabal file
  to make sure this stuff doesn't creep back in. For details of why this use
  of Control.Monad.Catch is unsafe, please refer to the documentation of this
  module.
Attachments
msg18232 (view) Author: gh Date: 2015-02-26.19:27:45
I observed that the bug is resolved by this patch. So the problem came
specifically from the withTemp function?

Also +1 for removing the dependency on exceptions.

I see that the change to withSSHConnection's body (not type) has not
been rollbacked, so we still have the ssh error reporting. We also keep
renderExecException and readInteractiveProcess.

Too bad there are a few useless blank lines hunk.

Accepted into 2.10, thanks
msg18235 (view) Author: bfrk Date: 2015-02-27.02:36:07
> I observed that the bug is resolved by this patch. So the problem came
> specifically from the withTemp function?

Yes. I plastered all possible candidates (including those which used the
"real" bracket function) with debug messages, so I could watch in real
time when a file was created and when it was deleted. It was only
withTemp that was broken.

Sorry about the blank lines. I know I should record things like that
separately.
History
Date User Action Args
2015-02-21 20:49:37bfrkcreate
2015-02-22 16:08:37bfrksetstatus: needs-screening -> needs-review
2015-02-26 19:27:45ghsetstatus: needs-review -> accepted
messages: + msg18232
milestone: 2.10.0
2015-02-27 02:36:08bfrksetmessages: + msg18235