darcs

Patch 1304 ErrorT is deprecated, switch to ExceptT (and 2 more)

Title ErrorT is deprecated, switch to ExceptT (and 2 more)
Superseder Nosy List ganesh, gh
Related Issues
Status accepted Assigned To
Milestone 2.10.0

Created on 2015-03-04.06:33:20 by ganesh, last changed 2015-03-07.15:37:42 by gh.

Files
File name Status Uploaded Type Edit Remove
errort-is-deprecated_-switch-to-exceptt.dpatch ganesh, 2015-03-04.06:33:20 application/x-darcs-patch
patch-preview.txt ganesh, 2015-03-04.06:33:20 text/x-darcs-patch
patch-preview.txt ganesh, 2015-03-04.22:42:50 text/x-darcs-patch
replace-pointless-import-of-control_monad_except.dpatch ganesh, 2015-03-04.22:42:50 application/x-darcs-patch
unnamed ganesh, 2015-03-04.06:33:20
unnamed ganesh, 2015-03-04.22:42:50
See mailing list archives for discussion on individual patches.
Messages
msg18255 (view) Author: ganesh Date: 2015-03-04.06:33:20
Fix some warnings: these should go into 2.10

3 patches for repository darcs-unstable@darcs.net:screened:

Tue Mar  3 19:06:41 GMT 2015  Ganesh Sittampalam <ganesh@earth.li>
  * ErrorT is deprecated, switch to ExceptT
  
  The two have different 'fail' implementations, but as far as
  I can see we don't have any explicit calls to that or any
  inexhaustive pattern matches in the relevant code.
  

Wed Mar  4 06:10:30 GMT 2015  Ganesh Sittampalam <ganesh@earth.li>
  * fix GHC 7.10 warning: explicitly quantify variables in type alias

Wed Mar  4 06:29:06 GMT 2015  Ganesh Sittampalam <ganesh@earth.li>
  * Turn off deprecation warning for use of 'parseTime' for now
Attachments
msg18257 (view) Author: bf Date: 2015-03-04.13:34:16
This breaks the build on my machine:

src/Darcs/Repository/ApplyPatches.hs:34:8:
    Could not find module `Control.Monad.Except'
    Perhaps you meant
      Control.Monad.Cont (from mtl-2.1.1)
      Control.Monad.Error (from mtl-2.1.1)
      Control.Monad.List (from mtl-2.1.1)
msg18263 (view) Author: ganesh Date: 2015-03-04.18:02:25
Sorry about that! Can you let me know what versions of mtl, 
transformers and transformers-compat you've got for this build? (I 
guess mtl=2.1.1 from the error message)
msg18264 (view) Author: gh Date: 2015-03-04.22:18:11
I'm getting this with ghc 7.6.3:

```
src/Darcs/Repository/ApplyPatches.hs:34:8:
    Could not find module `Control.Monad.Except'
    Perhaps you meant
      Control.Monad.Base (needs flag -package transformers-base-0.4.3)
      Control.Monad.Morph (needs flag -package mmorph-1.0.4)
      Control.Monad.Cont (needs flag -package monads-tf-0.1.0.1)
    Use -v to see a list of the files searched for.
Failed to install darcs-2.11.0
```

It tried to build darcs with transformers-compat-0.4.0.3.

"ghc-pkg list" tells me I have mtl-2.1.2 and transformers-0.3.0.0 installed.
msg18265 (view) Author: ganesh Date: 2015-03-04.22:42:50
This should fix the build break, apologies for the mistake.

1 patch for repository darcs-unstable@darcs.net:screened:

Wed Mar  4 22:41:39 GMT 2015  Ganesh Sittampalam <ganesh@earth.li>
  * replace pointless import of Control.Monad.Except
  
  This fixes the build with mtl<2.2.1
Attachments
msg18268 (view) Author: bf Date: 2015-03-06.03:26:52
Confirmed, build works again. Thanks.
msg18273 (view) Author: gh Date: 2015-03-07.15:37:42
Accepted (also into 2.10).
History
Date User Action Args
2015-03-04 06:33:21ganeshcreate
2015-03-04 06:38:39ganeshsetstatus: needs-screening -> needs-review
nosy: + gh
milestone: 2.10.0
2015-03-04 13:34:17bfsetmessages: + msg18257
2015-03-04 18:02:25ganeshsetmessages: + msg18263
2015-03-04 22:18:12ghsetmessages: + msg18264
2015-03-04 22:42:50ganeshsetfiles: + patch-preview.txt, replace-pointless-import-of-control_monad_except.dpatch, unnamed
messages: + msg18265
2015-03-06 03:26:52bfsetmessages: + msg18268
2015-03-07 15:37:42ghsetstatus: needs-review -> accepted
messages: + msg18273