darcs

Patch 1319 fix cloning with --lazy --tag .

Title fix cloning with --lazy --tag .
Superseder Nosy List gh
Related Issues
Status accepted Assigned To
Milestone 2.10.0

Created on 2015-04-03.21:00:47 by gh, last changed 2015-04-10.20:07:01 by gh.

Files
File name Status Uploaded Type Edit Remove
fix-cloning-with-__lazy-__tag-_.dpatch gh, 2015-04-03.21:00:46 application/x-darcs-patch
patch-preview.txt gh, 2015-04-03.21:00:46 text/x-darcs-patch
unnamed gh, 2015-04-03.21:00:46
See mailing list archives for discussion on individual patches.
Messages
msg18341 (view) Author: gh Date: 2015-04-03.21:00:46
When I did the refactoring to separate UI from Repository code,
I introduced a bug that broke `darcs clone URL --lazy --tag .`.
I removed the nesting of the "goingToSpecifiedVersion code"
inside of a withRepositoryLock. The consequence is that obliterating
(so, downloading) patches cannot be done automatically since
the code does not know about the correct sources of the new repository.

The fix is quite easy. Also, I think the cloning code needs refactoring
since we can clearly avoid re-invoking so many times withRepository,
withRepoLock and such.

1 patch for repository http://darcs.net:

patch 508a3226433451e6f8a9e5fcc937f0efd026f7c6
Author: Guillaume Hoffmann <guillaumh@gmail.com>
Date:   Fri Apr  3 17:47:48 ART 2015
  * fix cloning with --lazy --tag .
Attachments
msg18361 (view) Author: gh Date: 2015-04-10.20:07:01
No regrets, self-accept (into 2.10 also).
History
Date User Action Args
2015-04-03 21:00:47ghcreate
2015-04-03 21:10:04ghsetstatus: needs-screening -> needs-review
milestone: 2.10.0
2015-04-10 20:07:01ghsetstatus: needs-review -> accepted
messages: + msg18361