darcs

Patch 1323 resolve issue2448: enable -h/--hash flag for the diff ...

Title resolve issue2448: enable -h/--hash flag for the diff ...
Superseder Nosy List gpiero
Related Issues
Status accepted Assigned To
Milestone 2.10.0

Created on 2015-04-06.14:50:03 by gpiero, last changed 2015-04-18.17:06:27 by gh.

Files
File name Status Uploaded Type Edit Remove
patch-preview.txt gpiero, 2015-04-06.14:50:03 text/x-darcs-patch
resolve-issue2448_-enable-_h___hash-flag-for-the-diff-command.dpatch gpiero, 2015-04-06.14:50:03 application/x-darcs-patch
See mailing list archives for discussion on individual patches.
Messages
msg18350 (view) Author: gpiero Date: 2015-04-06.14:50:03
1 patch for repository http://darcs.net/screened:

patch 77cf49c48dccd5085a138118a8bb41f8f138c29e
Author: Gian Piero Carrubba <gpiero@rm-rf.it>
Date:   Mon Apr  6 16:46:39 CEST 2015
  * resolve issue2448: enable -h/--hash flag for the diff command
Attachments
msg18353 (view) Author: gh Date: 2015-04-06.20:27:25
Flag '-h' seems to be ignored. On my computer it only shows the diff of
the working copy.
msg18354 (view) Author: gh Date: 2015-04-06.20:36:10
Ah, with http://bugs.darcs.net/patch1322 it works. You should have added
that patch as explicit dependency of your patch (darcs rec --ask-deps)
to avoid such situations.  Can you amend it this way please?
msg18356 (view) Author: gpiero Date: 2015-04-06.21:05:41
* [Mon, Apr 06, 2015 at 08:36:10PM +0000] Guillaume Hoffmann:
>Ah, with http://bugs.darcs.net/patch1322 it works. You should have 
>added that patch as explicit dependency of your patch (darcs rec 
>--ask-deps) to avoid such situations.  Can you amend it this way 
>please?

Sorry, I was not expecting this dependency. Will look at it, in case the 
patches could be cleaned up. In the meantime, please don't screen 
neither this nor patch1322.

Thanks,
Gian Piero.
msg18367 (view) Author: gh Date: 2015-04-16.14:54:52
Any news? Do you plan to change something in the code, or just add the
dependency to this patch? I'd like to have both bundles in darcs 2.10.
If you only plan to add a dependency then it's probably more convenient
for everyone that I accept both bundles together.
msg18371 (view) Author: gh Date: 2015-04-17.19:46:58
Accepting (as it is) along with patch1322 (also in 2.10).
msg18372 (view) Author: gpiero Date: 2015-04-18.08:16:52
* [Thu, Apr 16, 2015 at 02:54:52PM +0000] Guillaume Hoffmann:
>Any news? Do you plan to change something in the code, or just add the
>dependency to this patch? I'd like to have both bundles in darcs 2.10.
>If you only plan to add a dependency then it's probably more convenient
>for everyone that I accept both bundles together.

Hi Guillame,

sorry, real life. I plan to look at it tomorrow, if it's not too late.

Ciao,
Gian Piero.
msg18379 (view) Author: gh Date: 2015-04-18.17:06:27
Hi Gian,

it's ok, I've accepted both bundles already.
History
Date User Action Args
2015-04-06 14:50:03gpierocreate
2015-04-06 20:27:25ghsetmessages: + msg18353
2015-04-06 20:36:10ghsetmessages: + msg18354
2015-04-06 21:05:41gpierosetmessages: + msg18356
2015-04-16 14:54:52ghsetmessages: + msg18367
2015-04-17 19:46:58ghsetstatus: needs-screening -> accepted
messages: + msg18371
milestone: 2.10.0
2015-04-18 08:16:53gpierosetmessages: + msg18372
2015-04-18 17:06:27ghsetmessages: + msg18379