Patch 1328: hashed-storage: replace C SHA256 bindings with externa... - Darcs bug tracker

Title	hashed-storage: replace C SHA256 bindings with externa...
Superseder		Nosy List	gh
Related Issues
Status	accepted	Assigned To
Milestone	2.10.0

Created on 2015-04-18.19:52:32 by gh, last changed 2015-04-19.20:52:51 by gh.

Files
File name	Status	Uploaded	Type	Edit	Remove
hashed_storage_-replace-c-sha256-bindings-with-external-libraries.dpatch		gh, 2015-04-18.19:52:31	application/x-darcs-patch
patch-preview.txt		gh, 2015-04-18.19:52:31	text/x-darcs-patch
unnamed		gh, 2015-04-18.19:52:31

See mailing list archives for discussion on individual patches.

Messages
msg18380 (view)	Author: gh	Date: 2015-04-18.19:52:31
For an unknown reason, "cabal sdist" does not include the file hashed-storage/Bundled/sha2.h in its output tarball, while it seems to know how to handle other header files in darcs' code. I realised that hashed-storage did not switch to cryptohash as did darcs with the patch "replace C SHA256 bindings with external libraries" in 2012. So this patch does the same for hashed-storage. Along with solving (avoiding) the "cabal sdist" bug, it saves us one module. 1 patch for repository http://darcs.net: patch a099745464a3f3b6682eb95e6a400832cbf00c69 Author: Guillaume Hoffmann <guillaumh@gmail.com> Date: Sat Apr 18 16:42:15 ART 2015 * hashed-storage: replace C SHA256 bindings with external libraries Attachments hashed_storage_-replace-c-sha256-bindings-with-external-libraries.dpatch patch-preview.txt unnamed
msg18382 (view)	Author: ganesh	Date: 2015-04-19.20:28:09
Looks fine to me.
msg18383 (view)	Author: gh	Date: 2015-04-19.20:52:51
Thanks, pushing it to reviewed and 2.10.

History
Date	User	Action	Args
2015-04-18 19:52:32	gh	create
2015-04-18 19:55:37	gh	set	status: needs-screening -> needs-review milestone: 2.10.0
2015-04-19 20:28:10	ganesh	set	status: needs-review -> accepted-pending-tests messages: + msg18382
2015-04-19 20:52:51	gh	set	status: accepted-pending-tests -> accepted messages: + msg18383