1 patch for repository darcs-unstable@darcs.net:screened:

Sun May 31 12:27:31 BST 2015  Ganesh Sittampalam <ganesh@earth.li>
  * remove the "diff algorithm" choice from the NameHack class

Attachments

• patch-preview.txt
• remove-the-_diff-algorithm_-choice-from-the-namehack-class.dpatch
• unnamed

1 patch for repository darcs-unstable@darcs.net:screened:

Sun May 31 13:12:54 BST 2015  Ganesh Sittampalam <ganesh@earth.li>
  * fix warnings

Attachments

• fix-warnings.dpatch
• patch-preview.txt
• unnamed

Hm, it looks to me as if this does not change behaviour, just refactors
code, right?

I guess the original idea was to make the choice of diff algorithm used
for the rebase patch configurable but that was never implemented?

Yes, this is just a refactoring.

The original introduction of the "diff algorithm" choice was done by 
a Summer of Code student who just ended up adding the parameter 
everywhere it was needed. This is just about taking a slightly more 
considered view of the right place to make the choice.

Rebase depends on the diff algorithm for a slightly silly reason - 
the "fixup" patches get coalesced to keep them as simple as 
possible, and that sometimes involves rerunning file changes through 
the diff algorithm.

I was originally planning on hard coding one option for everything 
in rebase, but it turned out that there are some commands that end 
up invoking rebase that select a value for the diff algorithm based 
on a command-line flag, so I decided to hold off from making a 
behaviour change for now.

Makes sense.