darcs

Patch 1382 resolve issue2461: darcs log --repo=remoterepo creates...

Title resolve issue2461: darcs log --repo=remoterepo creates...
Superseder Nosy List bf
Related Issues
Status accepted Assigned To
Milestone 2.10.1

Created on 2015-06-28.17:47:33 by bf, last changed 2015-07-04.15:06:36 by bf.

Files
File name Status Uploaded Type Edit Remove
patch-preview.txt bf, 2015-06-28.17:47:33 text/x-darcs-patch
patch-preview.txt bf, 2015-07-01.19:15:58 text/x-darcs-patch
patch-preview.txt bf, 2015-07-01.21:59:21 text/x-darcs-patch
resolve-issue2461_-darcs-log-__repo_remoterepo-creates-and-populates-_darcs.dpatch bf, 2015-06-28.17:47:33 application/x-darcs-patch
resolve-issue2461_-this-time-also-when-no-file-names-are-specified.dpatch bf, 2015-07-01.19:15:59 application/x-darcs-patch
resolve-issue2461_-this-time-also-when-no-file-names-are-specified.dpatch bf, 2015-07-01.21:59:21 application/x-darcs-patch
unnamed bf, 2015-06-28.17:47:33
unnamed bf, 2015-07-01.19:15:59
unnamed bf, 2015-07-01.21:59:21
See mailing list archives for discussion on individual patches.
Messages
msg18633 (view) Author: bf Date: 2015-06-28.17:47:33
1 patch for repository http://darcs.net/screened:

patch ca16adaaef0d048f216a7ae1939a098872645860
Author: Ben Franksen <benjamin.franksen@helmholtz-berlin.de>
Date:   Sun Jun 28 18:23:56 CEST 2015
  * resolve issue2461: darcs log --repo=remoterepo creates and populates _darcs
  
  The solution is to make a case distinction between remote and local usage.
  If we are working in a remote location, check that file arguments are
  relative paths and then do the log action inside a temporary directory.
Attachments
msg18647 (view) Author: gh Date: 2015-06-30.21:21:17
I haven't run the tests, but in screened, "darcs log
--repo=http://darcs.net" still creates a local _darcs directory with
this patch. Also in branch 2.10 + this patch.
msg18651 (view) Author: bf Date: 2015-07-01.19:15:59
1 patch for repository http://darcs.net/screened:

patch 807dfd7195309514598f28292691629d5efa1331
Author: Ben Franksen <benjamin.franksen@helmholtz-berlin.de>
Date:   Wed Jul  1 21:10:23 CEST 2015
  * resolve issue2461, this time also when no file names are specified
  
  Also slightly improve the error message when invalid arguments (non-relative
  paths) are given for remote repos.
Attachments
msg18652 (view) Author: gh Date: 2015-07-01.21:02:59
You should run the tests, your last patch prevents "darcs log" without
arguments from working inside of a local repository.
msg18653 (view) Author: bf Date: 2015-07-01.21:32:32
Sorry, stupid mistake. Will amend & re-send.
msg18654 (view) Author: bf Date: 2015-07-01.21:59:21
Amended (also slightly re-factored) version of the latest fix of the fix.
Ran the tests this time before sending ;)

1 patch for repository http://darcs.net/screened:

patch 47911083e7f069401697df70ecb0d2540f7a3597
Author: Ben Franksen <benjamin.franksen@helmholtz-berlin.de>
Date:   Wed Jul  1 21:10:23 CEST 2015
  * resolve issue2461, this time also when no file names are specified
  
  Also slightly improve the error message when invalid arguments (non-relative
  paths) are given for remote repos.
Attachments
msg18681 (view) Author: gh Date: 2015-07-03.22:03:20
Thanks, it works now, nice fix for 2.10.1!
msg18682 (view) Author: bf Date: 2015-07-04.10:24:50
There seems to be yet another possibility for this to fail. I added
these lines to tests/network/log.sh:

# also test that it works without any filename arguments
darcs log --repo=http://darcs.net --last 1

(Note that we are inside "/" at this moment.) This fails with

| darcs failed:  Not a repository: http://darcs.net (.:
openBinaryTempFile: permission denied (Permission denied))
| 
| HINT: Do you have the right URI for the repository?

However, when I try this outside of the test harness it works!

ben@sarun[1]: / > pwd
/
ben@sarun[1]: / > darcs log --repo=http://darcs.net --last 1
patch 050d575189bd701f7a214b7e1d01aebe17ea2ad9
Author: Ben Franksen <benjamin.franksen@helmholtz-berlin.de>
Date:   Thu Jul  2 15:06:28 CEST 2015
  * simplified code in D.R.Ssh by using withMVar
msg18684 (view) Author: bf Date: 2015-07-04.15:06:36
False alarm. I ran the tests with a stale darcs.
History
Date User Action Args
2015-06-28 17:47:33bfcreate
2015-06-28 20:23:28bfsetstatus: needs-screening -> needs-review
2015-06-29 13:30:56bflinkpatch1312 superseder
2015-06-30 21:21:18ghsetmessages: + msg18647
2015-07-01 19:15:59bfsetfiles: + patch-preview.txt, resolve-issue2461_-this-time-also-when-no-file-names-are-specified.dpatch, unnamed
messages: + msg18651
2015-07-01 21:03:00ghsetmessages: + msg18652
2015-07-01 21:32:32bfsetmessages: + msg18653
2015-07-01 21:59:21bfsetfiles: + patch-preview.txt, resolve-issue2461_-this-time-also-when-no-file-names-are-specified.dpatch, unnamed
messages: + msg18654
2015-07-03 22:03:20ghsetstatus: needs-review -> accepted
messages: + msg18681
milestone: 2.10.1
2015-07-04 10:24:54bfsetmessages: + msg18682
2015-07-04 15:06:36bfsetmessages: + msg18684