darcs

Patch 1395 inline patchSetToPatches in the only pla... (and 2 more)

Title inline patchSetToPatches in the only pla... (and 2 more)
Superseder Nosy List galbolle, gh
Related Issues
Status accepted Assigned To
Milestone 2.10.2

Created on 2015-09-19.21:40:55 by gh, last changed 2015-10-09.19:35:55 by gh.

Files
File name Status Uploaded Type Edit Remove
inline-patchsettopatches-in-the-only-place-where-it-is-used.dpatch gh, 2015-09-19.21:40:55 application/x-darcs-patch
patch-preview.txt gh, 2015-09-19.21:40:55 text/x-darcs-patch
unnamed gh, 2015-09-19.21:40:55
See mailing list archives for discussion on individual patches.
Messages
msg18737 (view) Author: gh Date: 2015-09-19.21:40:55
3 refactorings done while looking into http://bugs.darcs.net/issue2436 .

The third one (make patch selection lazier) actually does a difference
when moving around lots of patches (~19 to ~11seconds when running
"darcs rollback -p ." on darcs' repo),
althought it does not solve the underlying issue of the aforementioned
bug.

3 patches for repository http://darcs.net:

patch 9cfe94d440f65c2891316abbcd50b57706de695e
Author: Guillaume Hoffmann <guillaumh@gmail.com>
Date:   Fri Sep 18 08:50:33 ART 2015
  * inline patchSetToPatches in the only place where it is used

patch 03b925ae81a3499c447dbe53954cb472c8894483
Author: Guillaume Hoffmann <guillaumh@gmail.com>
Date:   Sat Sep 19 18:33:59 ART 2015
  * get rid of selectChanges

patch 4d55c7ccc1e8cbd80066c05d66e6309bd96aed8e
Author: Guillaume Hoffmann <guillaumh@gmail.com>
Date:   Sat Sep 19 18:36:48 ART 2015
  * make patch selection lazier in presence of matchers
Attachments
msg18739 (view) Author: gh Date: 2015-09-20.08:47:27
The bundle is screened.  If accepted , the patch "make patch selection
lazier in presence of matchers" should make it into dacs 2.10.2 .
msg18770 (view) Author: gh Date: 2015-10-05.18:22:07
I would self accept the bundle but I kind of regret the patch "get rid
of selectChanges" now that I remember that Florent did some work on
SelectChanges two years ago which was never merged (see
http://blog.darcs.net/2013/02/darcs-hacking-sprint-8-report.html ). I
wrote to him about it and am waiting for his answer.
msg18771 (view) Author: gh Date: 2015-10-09.19:35:55
According to Florent, the "get rid of selectChanges" patch is not
harmful for his refactoring, so I'm self-accepting the bundle.
History
Date User Action Args
2015-09-19 21:40:55ghcreate
2015-09-20 08:47:28ghsetstatus: needs-screening -> needs-review
messages: + msg18739
2015-10-05 18:22:08ghsetmessages: + msg18770
2015-10-05 18:22:17ghsetnosy: + galbolle
2015-10-09 19:35:55ghsetstatus: needs-review -> accepted
messages: + msg18771
milestone: 2.10.2