darcs

Patch 1397 implement function getDeps (and 1 more)

Title implement function getDeps (and 1 more)
Superseder Nosy List gh
Related Issues
Status accepted Assigned To
Milestone

Created on 2015-09-20.12:31:29 by gh, last changed 2016-02-12.17:17:46 by gh.

Files
File name Status Uploaded Type Edit Remove
implement-function-getdeps.dpatch gh, 2015-09-20.12:31:29 application/x-darcs-patch
patch-preview.txt gh, 2015-09-20.12:31:29 text/x-darcs-patch
patch-preview.txt gh, 2016-02-01.16:49:39 text/x-darcs-patch
show-dependencies-up-to-last-tag-by-default.dpatch gh, 2016-02-01.16:49:39 application/x-darcs-patch
unnamed gh, 2015-09-20.12:31:29
unnamed gh, 2016-02-01.16:49:39 text/plain
See mailing list archives for discussion on individual patches.
Messages
msg18746 (view) Author: gh Date: 2015-09-20.12:31:29
2 patches for repository http://darcs.net:

patch 5beadb4985cdb02d99218f2e926d268cd0ae3603
Author: Guillaume Hoffmann <guillaumh@gmail.com>
Date:   Sun Sep 20 07:15:40 ART 2015
  * implement function getDeps
  Based on work by Ale Gadea.

patch 0815ad1fb720982d3b62853b8a3d51f97777484f
Author: Guillaume Hoffmann <guillaumh@gmail.com>
Date:   Sun Sep 20 09:29:52 ART 2015
  * darcs show dependencies
  Based on work by Ale Gadea.
Attachments
msg18943 (view) Author: ganesh Date: 2016-01-19.17:42:47
'darcs show dependencies' without any arguments is prohibitively slow 
on large repositories - should it default to something like starting 
from the last tag?
msg18944 (view) Author: gh Date: 2016-01-20.12:33:12
Yes it is super-slow, but if we default it to the last tag (which sounds
reasonable), can we un-default it with some commandline flag?
msg19009 (view) Author: gh Date: 2016-02-01.16:49:39
This is much more usable:  'show dependencies' now shows them up
to last tag. It is still possible to use --from-tag and such, to
go further back in time.

I added a second patch to make the pdf more readable.

2 patches for repository http://darcs.net:

patch 58abe7deb6824b14f43f732e1c2403081e951286
Author: Guillaume Hoffmann <guillaumh@gmail.com>
Date:   Mon Feb  1 13:36:11 ART 2016
  * show dependencies up to last tag by default

patch 7a0c614292ddd26af3abf12c579439e3e85927eb
Author: Guillaume Hoffmann <guillaumh@gmail.com>
Date:   Mon Feb  1 13:58:11 ART 2016
  * format patch names within 20 characters in dependencies output
Attachments
msg19012 (view) Author: gh Date: 2016-02-03.09:53:47
In Darcs' repository the feature works quite fast since a lot of patches
are about different files, so they commute quickly. But in a repository
with a lot of non-commuting patches, it's quite slow and impractical.

Try the following:

    darcs clone http://pijul.org
    *obliterate the last tag*
    darcs show dependencies --last=140 | dot -Tpdf -o FILE.pdf

Try increasing the number of patches to 150 or more, and observe that it
becomes much slower. I'm not sure we can do something about it?
msg19028 (view) Author: gh Date: 2016-02-12.17:17:46
I think we can accept this now and work on performance later.
History
Date User Action Args
2015-09-20 12:31:29ghcreate
2015-09-20 12:32:13ghsetstatus: needs-screening -> needs-review
2016-01-19 17:42:47ganeshsetmessages: + msg18943
2016-01-20 12:33:13ghsetmessages: + msg18944
2016-02-01 16:49:39ghsetfiles: + patch-preview.txt, show-dependencies-up-to-last-tag-by-default.dpatch, unnamed
messages: + msg19009
2016-02-03 09:53:48ghsetmessages: + msg19012
2016-02-12 17:17:46ghsetstatus: needs-review -> accepted
messages: + msg19028