darcs

Patch 1430 break RebaseItem out into its own file (and 4 more)

Title break RebaseItem out into its own file (and 4 more)
Superseder Nosy List ganesh
Related Issues
Status accepted Assigned To
Milestone

Created on 2016-01-16.11:54:05 by ganesh, last changed 2016-01-17.09:14:47 by gh.

Files
File name Status Uploaded Type Edit Remove
break-rebaseitem-out-into-its-own-file.dpatch ganesh, 2016-01-16.11:54:05 application/x-darcs-patch
patch-preview.txt ganesh, 2016-01-16.11:54:05 text/x-darcs-patch
unnamed ganesh, 2016-01-16.11:54:05 text/plain
See mailing list archives for discussion on individual patches.
Messages
msg18927 (view) Author: ganesh Date: 2016-01-16.11:54:05
A few simple/independent refactorings of the rebase code
(broken out from the upcoming bigger refactoring)

5 patches for repository darcs-unstable@darcs.net:screened:

patch 426742f30ba9bbba60db43e5c5a56f1d2f8a8714
Author: Ganesh Sittampalam <ganesh@earth.li>
Date:   Wed Aug  5 21:24:38 BST 2015
  * break RebaseItem out into its own file

patch 61c6eb6cccbd5cef5887c02607d371145220519e
Author: Ganesh Sittampalam <ganesh@earth.li>
Date:   Thu Aug  6 21:31:33 BST 2015
  * move Rebasing out into its own module

patch 4100b7cabb5e8aae8c06c2c041cb289fb490e6fc
Author: Ganesh Sittampalam <ganesh@earth.li>
Date:   Fri Aug 28 07:11:30 BST 2015
  * implement hunkMatches for PatchInfoAnd
  There doesn't seem any reason not to have it and it allows
  simplifying other code.

patch d5d22e9097ad2a9062e15505853d99384f0350db
Author: Ganesh Sittampalam <ganesh@earth.li>
Date:   Fri Aug 28 07:28:21 BST 2015
  * simplify the PatchInspect (Rebasing p) instance

patch b626e4f4c666056103cdc77e7425782559f4dee1
Author: Ganesh Sittampalam <ganesh@earth.li>
Date:   Fri Sep 11 07:03:51 BST 2015
  * drop unneeded export
Attachments
msg18934 (view) Author: gh Date: 2016-01-17.09:14:44
* break RebaseItem out into its own file
  
moves Item-related code to Darcs.Patch.Rebase.Item , and one name-related
function to Darcs.Patch.Rebase.Name (from Darcs.Patch.Rebase).

* move Rebasing out into its own module

Introduces Darcs.Patch.Rebase.Container, which handles the patch that
represents the rebased state. Moves code from Darcs.Patch.Rebase to this
new module.

* implement hunkMatches for PatchInfoAnd

ok; previous code was strangely incomplete indeed.

* simplify the PatchInspect (Rebasing p) instance

It does so by introducing a PatchInspect (RebaseItem p) instance. OK.

* drop unneeded export

OK.


Accepted.
History
Date User Action Args
2016-01-16 11:54:05ganeshcreate
2016-01-17 08:47:57ghsetstatus: needs-screening -> needs-review
2016-01-17 09:14:47ghsetstatus: needs-review -> accepted
messages: + msg18934