darcs

Patch 1431 capture diffAlgorithm in splitters inste... (and 1 more)

Title capture diffAlgorithm in splitters inste... (and 1 more)
Superseder Nosy List ganesh
Related Issues
Status accepted Assigned To
Milestone

Created on 2016-01-16.14:56:09 by ganesh, last changed 2016-01-17.09:43:24 by gh.

Files
File name Status Uploaded Type Edit Remove
capture-diffalgorithm-in-splitters-instead-of-passing-it-to-selectchanges-unconditionally.dpatch ganesh, 2016-01-16.14:56:08 application/x-darcs-patch
patch-preview.txt ganesh, 2016-01-16.14:56:08 text/x-darcs-patch
unnamed ganesh, 2016-01-16.14:56:08 text/plain
See mailing list archives for discussion on individual patches.
Messages
msg18929 (view) Author: ganesh Date: 2016-01-16.14:56:08
simplify the way we pass DiffAlgorithm to splitters
2 patches for repository darcs-unstable@darcs.net:screened:

patch 40548bf8aa56e5038762e65be59c1b399b490600
Author: Ganesh Sittampalam <ganesh@earth.li>
Date:   Sun Sep 13 15:28:26 BST 2015
  * capture diffAlgorithm in splitters instead of passing it to SelectChanges unconditionally

patch fe2f003cce0b8a30c7beafb93221af9978a95487
Author: Ganesh Sittampalam <ganesh@earth.li>
Date:   Sat Jan 16 14:49:48 GMT 2016
  * resolve conflicts between changes to splitters and to hijacking
Attachments
msg18935 (view) Author: gh Date: 2016-01-17.09:43:24
I reviewed both patch together because showing the diff of the
conflicting patch only (without resolution patch) shows incorrect stuff.
So I did:

    darcs diff --from-hash 40548bf8aa  --to-hash fe2f003cce

* capture diffAlgorithm in splitters instead of passing it to
SelectChanges unconditionally

The changes of the patch is to removes the diffAlgorithm field
from the SelectChagnes and put this option instead of splitters. The
result is that UI commands that do not need to edit hunks (for instance,
pull, push) no longer have to specify a diff algorithm to call interactive
selection. This is a nice change. And tests pass.

Accepted.
History
Date User Action Args
2016-01-16 14:56:09ganeshcreate
2016-01-17 08:47:40ghsetstatus: needs-screening -> needs-review
2016-01-17 09:43:24ghsetstatus: needs-review -> accepted
messages: + msg18935