darcs

Patch 1432 do not open patches uselessly when no file restriction...

Title do not open patches uselessly when no file restriction...
Superseder Nosy List gh
Related Issues
Status accepted Assigned To
Milestone

Created on 2016-01-16.17:23:01 by gh, last changed 2016-01-25.18:10:45 by gh.

Files
File name Status Uploaded Type Edit Remove
do-not-open-patches-uselessly-when-no-file-restriction-given.dpatch gh, 2016-01-16.17:23:01 application/x-darcs-patch
do-not-open-patches-uselessly-when-no-file-restriction-given.dpatch gh, 2016-01-17.08:53:20 application/x-darcs-patch
patch-preview.txt gh, 2016-01-16.17:23:01 text/x-darcs-patch
patch-preview.txt gh, 2016-01-17.08:53:20 text/x-darcs-patch
unnamed gh, 2016-01-16.17:23:01 text/plain
unnamed gh, 2016-01-17.08:53:20 text/plain
See mailing list archives for discussion on individual patches.
Messages
msg18931 (view) Author: gh Date: 2016-01-16.17:23:01
There is still more to do to solve http://bugs.darcs.net/issue2436
(the next step would be to make matching before interactive selection
lazy),
but at least "rollbak -p ." stops opening all patches of the current
repository before the first prompt.

1 patch for repository http://darcs.net:

patch 7147b93fea11a899493099f166490dae154b1f29
Author: Guillaume Hoffmann <guillaumh@gmail.com>
Date:   Sat Jan 16 14:28:35 ART 2016
  * do not open patches uselessly when no file restriction given
  With this change commands like "darcs rollback -p ." stop
  opening all patches.
  Done with the invaluable help of Florent Becker.
Attachments
msg18933 (view) Author: gh Date: 2016-01-17.08:53:20
Improved comments.

I'm screening it.

1 patch for repository http://darcs.net:

patch fd0eab4d10c24d2730caee8e2dba3829c5ea9cbd
Author: Guillaume Hoffmann <guillaumh@gmail.com>
Date:   Sun Jan 17 06:00:57 ART 2016
  * do not open patches uselessly when no file restriction given
  With this change commands like "darcs rollback -p ." stop
  opening all patches.
  Done with the invaluable help of Florent Becker.
Attachments
msg18937 (view) Author: gh Date: 2016-01-17.12:46:02
I tried again without this patch, and darcs did *not* open all patches
during interactive selection.  I think there was a confusion on my
machine with testing with the OS version of Darcs (2.10.1) which had the
bug.

So the path does not fix anything special. One can see in
Darcs.Patch.TouchesFiles that when the given list of files is Nothing,
the patch is not read (select.. and deselect.. functions).

Anyway it's good to have this change to clarify the source code.
msg18965 (view) Author: gh Date: 2016-01-25.18:10:19
self-accept
History
Date User Action Args
2016-01-16 17:23:01ghcreate
2016-01-17 08:34:53ghsetmilestone: 2.10.3
2016-01-17 08:53:21ghsetfiles: + patch-preview.txt, do-not-open-patches-uselessly-when-no-file-restriction-given.dpatch, unnamed
messages: + msg18933
2016-01-17 08:56:51ghsetstatus: needs-screening -> needs-review
2016-01-17 12:46:03ghsetmessages: + msg18937
2016-01-25 18:10:19ghsetmessages: + msg18965
milestone: 2.10.3 ->
2016-01-25 18:10:45ghsetstatus: needs-review -> accepted