darcs

Patch 1436 resolve issue2489: dequote filepaths while importing f...

Title resolve issue2489: dequote filepaths while importing f...
Superseder Nosy List gh, owst
Related Issues
Status accepted Assigned To
Milestone 2.10.3

Created on 2016-01-21.12:19:33 by gh, last changed 2016-01-28.17:14:37 by gh.

Files
File name Status Uploaded Type Edit Remove
patch-preview.txt gh, 2016-01-21.12:19:33 text/x-darcs-patch
patch-preview.txt gh, 2016-01-22.13:25:55 text/x-darcs-patch
resolve-issue2489_-dequote-filepaths-while-importing-from-git.dpatch gh, 2016-01-21.12:19:33 application/x-darcs-patch
test-for-checking-filepaths-consistency-with-git.dpatch gh, 2016-01-22.13:25:55 application/x-darcs-patch
unnamed gh, 2016-01-21.12:19:33 text/plain
unnamed gh, 2016-01-22.13:25:55 text/plain
See mailing list archives for discussion on individual patches.
Messages
msg18948 (view) Author: gh Date: 2016-01-21.12:19:33
1 patch for repository http://darcs.net:

patch 430a8b03bd0f4736ff6252afe4bad4770ad0741d
Author: Guillaume Hoffmann <guillaumh@gmail.com>
Date:   Thu Jan 21 09:27:14 ART 2016
  * resolve issue2489: dequote filepaths while importing from git
Attachments
msg18950 (view) Author: gh Date: 2016-01-21.15:26:30
This one can make it to 2.10.3; it's nice to have and easy to review.
Anyone?
msg18951 (view) Author: ganesh Date: 2016-01-21.17:57:29
Worth a test? Also do we need to quote filepaths when exporting to git?

Happy to accept it as-is if you think it's not necessary/worth it.
msg18953 (view) Author: gh Date: 2016-01-22.13:25:55
Testing shows that quoting is not necessary for git to import
correctly a darcs repo with spaces in some paths. But anyway
I looking into Owen's darcs-bridge and ported the code useful
for escaping and unescaping, so here is:

*  a test that ensures that weird filenames are correctly
   handled in both directions between darcs and git
*  Owen's code for escaping/unescaping
*  a rollback of my previous patch

I trust this code much more :)

(Now it makes me think that we could port more from
Owen's darcs-bridge...)

3 patches for repository http://darcs.net:

patch c5305a36ab4513397bdcff84d12c1244c37d6766
Author: Guillaume Hoffmann <guillaumh@gmail.com>
Date:   Fri Jan 22 10:21:36 ART 2016
  * test for checking filepaths consistency with git
  Test partially copied from Owen Stephen's darcs-bridge test.

patch 74cdb73df2932c3465e2c575138b2d6c7bc6026f
Author: Guillaume Hoffmann <guillaumh@gmail.com>
Date:   Fri Jan 22 10:25:25 ART 2016
  * quoting and escaping of filenames in convert export and import
  Ported from darcs-bridge code by Owen Stephens.

patch fe2911ad94e1765c91cbeb64d8109420eafbf963
Author: Guillaume Hoffmann <guillaumh@gmail.com>
Date:   Fri Jan 22 10:30:13 ART 2016
  * rollback filename dequoting on import since now done during parsing
Attachments
msg18991 (view) Author: gh Date: 2016-01-28.17:14:37
Greenlighted by Owen on IRC.
History
Date User Action Args
2016-01-21 12:19:33ghcreate
2016-01-21 13:19:11ghsetstatus: needs-screening -> needs-review
2016-01-21 15:26:31ghsetmessages: + msg18950
milestone: 2.10.3
2016-01-21 17:57:30ganeshsetstatus: needs-review -> review-in-progress
messages: + msg18951
2016-01-22 13:25:56ghsetfiles: + patch-preview.txt, test-for-checking-filepaths-consistency-with-git.dpatch, unnamed
messages: + msg18953
2016-01-25 20:48:58ganeshsetstatus: review-in-progress -> needs-review
2016-01-26 10:50:22ghsetnosy: + owst
2016-01-28 17:14:37ghsetstatus: needs-review -> accepted
messages: + msg18991