A few more patches broken out from my rebase
refactoring, hopefully digestible on their own.

13 patches for repository darcs-unstable@darcs.net:screened:

patch ea83eaa82f7000418272c083b463171ac0b2d3db
Author: Ganesh Sittampalam <ganesh@earth.li>
Date:   Mon Jan 25 18:31:51 GMT 2016
  * Introduce a 'Suspended' type to encapsulate 'FL RebaseItem'
  
  This allows us to encapsulate the behaviour of the suspended
  container and simplify future refactorings.
  

patch d3eb959c022ced5bdae6ae38322fd4ad50141a96
Author: Ganesh Sittampalam <ganesh@earth.li>
Date:   Mon Jan 25 18:36:10 GMT 2016
  * abstract out an instance ShowPatchBasic Suspended

patch 45750b5179bc15bde39cb239431f1180e2618cd6
Author: Ganesh Sittampalam <ganesh@earth.li>
Date:   Mon Jan 25 18:22:32 GMT 2016
  * inline a couple of defaults to simplify future refactoring

patch 934565bb5c3c647d041a2d904bf987378125457f
Author: Ganesh Sittampalam <ganesh@earth.li>
Date:   Mon Jan 25 18:41:08 GMT 2016
  * refactor instance ShowPatch Rebasing a bit
  
  breaking out separate cases for Normal/Suspended and inlining
  from the definition of showPatch
  

patch abdfc88dc5f94f37952cadcccf3dc348dc9536fb
Author: Ganesh Sittampalam <ganesh@earth.li>
Date:   Mon Jan 25 18:47:25 GMT 2016
  * break out Apply instance for Suspended

patch 03d00169b545430e5c83a091e4cf9c7438bbe0d2
Author: Ganesh Sittampalam <ganesh@earth.li>
Date:   Mon Jan 25 18:47:48 GMT 2016
  * break out ShowPatch instance for Suspended

patch b1c1db4aa34ba2c142475eaa0171760ff101254d
Author: Ganesh Sittampalam <ganesh@earth.li>
Date:   Mon Jan 25 18:56:32 GMT 2016
  * add PrimPatchBase instance for Suspended

patch 2724890bd4983b11f847009c94886eed20262b81
Author: Ganesh Sittampalam <ganesh@earth.li>
Date:   Mon Jan 25 18:56:40 GMT 2016
  * break out Effect instance for Suspended

patch 1d5a9452c5dfdf8a598174027a2999ed5f00058c
Author: Ganesh Sittampalam <ganesh@earth.li>
Date:   Mon Jan 25 18:56:40 GMT 2016
  * break out Conflict instance for Suspended

patch b04c190f0681b2dcd5adcf4271e4c3d883f89c25
Author: Ganesh Sittampalam <ganesh@earth.li>
Date:   Mon Jan 25 19:03:00 GMT 2016
  * break out Show instances for Suspended
  This changes the output, but the instances should only be used
  for debugging.

patch db1e9d6790c871871517cbae8ee74d6700df3836
Author: Ganesh Sittampalam <ganesh@earth.li>
Date:   Mon Jan 25 19:45:25 GMT 2016
  * break out Check instance for Suspended

patch 6049e972e34c599de4c7fb50a8dbedc837d7aa2e
Author: Ganesh Sittampalam <ganesh@earth.li>
Date:   Mon Jan 25 19:48:22 GMT 2016
  * break out ReadPatch instance for Suspended

patch 2424b567006af3b00e00cfdde5592d6ee50f1a38
Author: Ganesh Sittampalam <ganesh@earth.li>
Date:   Mon Jan 25 19:50:15 GMT 2016
  * break out RepairToFL instance for Suspended

Attachments

• introduce-a-_suspended_-type-to-encapsulate-_fl-rebaseitem_.dpatch
• patch-preview.txt
• unnamed

1 patch for repository darcs-unstable@darcs.net:screened:

patch 8358a42ebecb29b86d3702327e783c729729c1e8
Author: Ganesh Sittampalam <ganesh@earth.li>
Date:   Wed Jan 27 18:29:18 GMT 2016
  * use Suspended instead of FL RebaseItem in take*Rebase*

Attachments

• patch-preview.txt
• unnamed
• use-suspended-instead-of-fl-rebaseitem-in-take_rebase_.dpatch

1 patch for repository darcs-unstable@darcs.net:screened:

patch 316383669ab10939fcdd7a59f39d69f41acb848c
Author: Ganesh Sittampalam <ganesh@earth.li>
Date:   Fri Jan 29 19:03:20 GMT 2016
  * rename mkSuspended to mkRebase and make it work on 'Suspended'

Attachments

• patch-preview.txt
• rename-mksuspended-to-mkrebase-and-make-it-work-on-_suspended_.dpatch
• unnamed

1 patch for repository darcs-unstable@darcs.net:screened:

patch 3b8c66027ca15f1d014bf3b2e019ecedb6527065
Author: Ganesh Sittampalam <ganesh@earth.li>
Date:   Mon Feb  1 06:05:46 GMT 2016
  * break out PatchInspect instance for Suspended

Attachments

• break-out-patchinspect-instance-for-suspended.dpatch
• patch-preview.txt
• unnamed

1 patch for repository darcs-unstable@darcs.net:screened:

patch 56f4aa51586811086c75ca4696331da70f4b92ec
Author: Ganesh Sittampalam <ganesh@earth.li>
Date:   Fri Feb 12 23:56:05 GMT 2016
  * simplify instance ShowPatchBasic (RebaseSelect p)

Attachments

• patch-preview.txt
• simplify-instance-showpatchbasic-_rebaseselect-p_.dpatch
• unnamed

1 patch for repository darcs-unstable@darcs.net:screened:

patch 669741ca1284d81d003cf2967b6a59212145b31e
Author: Ganesh Sittampalam <ganesh@earth.li>
Date:   Tue Feb 16 06:08:57 GMT 2016
  * add Repair instance for Suspended

Attachments

• add-repair-instance-for-suspended.dpatch
• patch-preview.txt
• unnamed

2 patches for repository darcs-unstable@darcs.net:screened:

patch 772f3b4021f4e8419da6f99c0d0535a6a18adaa1
Author: Ganesh Sittampalam <ganesh@earth.li>
Date:   Wed Feb 17 06:41:11 GMT 2016
  * move addFixup to Rebase.Container and give it a clearer name

patch 12bdc0d50d6d4fbb11917358a372bd99b0c06514
Author: Ganesh Sittampalam <ganesh@earth.li>
Date:   Wed Feb 17 06:41:11 GMT 2016
  * add versions of simplifyPush[es] for Suspended
  
  It would be nice to use them in Darcs.UI.Commands.Rebase too,
  but that is currently very much based around manipulating
  FL (RebaseItem p) directly, so isn't a trivial refactoring.

Attachments

• move-addfixup-to-rebase_container-and-give-it-a-clearer-name.dpatch
• patch-preview.txt
• unnamed

TLDR: everything looks good, accepting.


* Introduce a 'Suspended' type to encapsulate 'FL RebaseItem':     OK

* abstract out an instance ShowPatchBasic Suspended:    OK

* inline a couple of defaults to simplify future refactoring: OK

* refactor instance ShowPatch Rebasing a bit: OK

* break out Apply instance for Suspended: OK

* break out ShowPatch instance for Suspended: OK

* add PrimPatchBase instance for Suspended: OK

* break out Effect instance for Suspended: OK

* break out Conflict instance for Suspended: OK

* break out Show instances for Suspended: OK. I was not aware of the
  StandaloneDeriving extension but it's present since at least GHC 7.4
  (see eg
 
https://downloads.haskell.org/~ghc/7.4.2/docs/html/users_guide/deriving.html
)

* break out Check instance for Suspended: OK

* break out ReadPatch instance for Suspended: OK looks correct

* break out RepairToFL instance for Suspended: OK

* use Suspended instead of FL RebaseItem in take*Rebase*:  OK, nice, it's
  the first application of the Suspended refactoring to the UI code

* rename mkSuspended to mkRebase and make it work on 'Suspended': OK

* break out PatchInspect instance for Suspended: OK

* simplify instance ShowPatchBasic (RebaseSelect p): OK

* add Repair instance for Suspended: OK

* move addFixup to Rebase.Container and give it a clearer name: OK

* add versions of simplifyPush[es] for Suspended: OK (this helps simplify
  a couple of funcions in Container)