darcs

Patch 1442 bump dependencies lower bounds implied by requiring gh...

Title bump dependencies lower bounds implied by requiring gh...
Superseder Nosy List ganesh, gh
Related Issues
Status accepted Assigned To
Milestone

Created on 2016-01-26.14:30:41 by gh, last changed 2016-03-22.16:59:39 by gh.

Files
File name Status Uploaded Type Edit Remove
bump-dependencies-lower-bounds-implied-by-requiring-ghc-7_6.dpatch gh, 2016-01-26.14:30:41 application/x-darcs-patch
bump-second-html-dependency.dpatch gh, 2016-01-26.14:34:58 application/x-darcs-patch
patch-preview.txt gh, 2016-01-26.14:30:41 text/x-darcs-patch
patch-preview.txt gh, 2016-01-26.14:34:58 text/x-darcs-patch
patch-preview.txt gh, 2016-01-28.14:08:14 text/x-darcs-patch
require-cabal-1_20-and-rollback-template-haskell-trick-in-setup_lhs.dpatch dead gh, 2016-01-28.14:08:14 application/x-darcs-patch
unnamed gh, 2016-01-26.14:30:41 text/plain
unnamed gh, 2016-01-26.14:34:58 text/plain
unnamed gh, 2016-01-28.14:08:14 text/plain
See mailing list archives for discussion on individual patches.
Messages
msg18971 (view) Author: gh Date: 2016-01-26.14:30:41
See https://www.haskell.org/platform/contents.html
and https://packages.debian.org/jessie/haskell-platform .

1 patch for repository http://darcs.net:

patch b4b484e2e01f6e807aa51047ea8ea2d825e59a3d
Author: Guillaume Hoffmann <guillaumh@gmail.com>
Date:   Tue Jan 26 11:31:50 ART 2016
  * bump dependencies lower bounds implied by requiring ghc 7.6
  See https://www.haskell.org/platform/changelog.html
Attachments
msg18972 (view) Author: gh Date: 2016-01-26.14:34:58
1 patch for repository http://darcs.net:

patch 8978a9326874ed792b0d3c8c4ee1c95936963cb2
Author: Guillaume Hoffmann <guillaumh@gmail.com>
Date:   Tue Jan 26 11:44:31 ART 2016
  * bump second html dependency
Attachments
msg18973 (view) Author: gh Date: 2016-01-26.15:08:26
I wonder if we can also require cabal 1.20 [1] and then rollback the
following patch to simplify Setup.lhs:

    patch 850bd63d03fb36f10a0c999f35eb2ea8b44c5192
    Author: Ganesh Sittampalam <ganesh@earth.li>
    Date:   Tue Jun  3 03:16:39 ART 2014
      * conditionalise replHook using Template Haskell

[1] https://packages.debian.org/jessie/cabal-install
msg18974 (view) Author: ganesh Date: 2016-01-26.17:57:01
I'm using 1.18 in my GHC 7.6 environment, but there probably isn't any 
good reason for that. But I'm also not sure it's worth removing this 
too aggressively, unless someone needs to touch anything else in that 
area.
msg18977 (view) Author: gh Date: 2016-01-26.21:36:47
In this case, more than just bumping lower bounds to reduce the possible
combinations of libraries to build darcs, I'm more concerned about
having code that's easy to understand.

I would say the change is worth it if we can assume that the typical
user of ghc 7.6 can get cabal 1.20 easily. Is it the case?
msg18988 (view) Author: gh Date: 2016-01-28.14:08:14
This is what the rollback patch would look like:

1 patch for repository http://darcs.net:

patch 5838a1d222e0979b5cf256d1406d133fa96a2f21
Author: Guillaume Hoffmann <guillaumh@gmail.com>
Date:   Tue Jan 26 12:26:21 ART 2016
  * require cabal 1.20 and rollback template haskell trick in Setup.lhs
Attachments
msg18994 (view) Author: ganesh Date: 2016-01-28.19:33:22
I've checked and I can personally use Cabal 1.20 fine.

But the HP that came with GHC 7.6.2 had Cabal 1.16: 
https://github.com/haskell/haskell-
platform/blob/master/hptool/src/Releases2013.hs

I think it'd be more logical to wait till our minimum GHC version is 
7.10, unless it causes any actual problems. If anyone wants to 
refactor Setup.hs, it'd definitely be a good candidate for dropping.
msg19001 (view) Author: gh Date: 2016-01-29.11:25:51
OK, then it's better we wait before bumping the Cabal dependency.

What about the other two patches?
msg19008 (view) Author: gh Date: 2016-02-01.15:14:58
Self-accepting the dependency bumps, safe in light of Haskell-Platform
2013.2.0.0 ( https://www.haskell.org/platform/contents.html ).
msg19010 (view) Author: ganesh Date: 2016-02-01.17:24:43
Sorry for not replying earlier, but that all seems fine to me.
History
Date User Action Args
2016-01-26 14:30:41ghcreate
2016-01-26 14:34:58ghsetfiles: + patch-preview.txt, bump-second-html-dependency.dpatch, unnamed
messages: + msg18972
2016-01-26 15:07:27ghsetstatus: needs-screening -> needs-review
2016-01-26 15:08:28ghsetnosy: + ganesh
messages: + msg18973
2016-01-26 17:57:01ganeshsetmessages: + msg18974
2016-01-26 21:36:48ghsetmessages: + msg18977
2016-01-28 14:08:15ghsetfiles: + patch-preview.txt, require-cabal-1_20-and-rollback-template-haskell-trick-in-setup_lhs.dpatch, unnamed
messages: + msg18988
2016-01-28 19:33:22ganeshsetmessages: + msg18994
2016-01-29 11:25:51ghsetmessages: + msg19001
2016-02-01 15:14:59ghsetstatus: needs-review -> accepted-pending-tests
messages: + msg19008
2016-02-01 17:24:43ganeshsetmessages: + msg19010
2016-03-22 16:59:39ghsetstatus: accepted-pending-tests -> accepted