Patch 1444: fix tests that use "git commit" (and 1 more) - Darcs bug tracker

Title	fix tests that use "git commit" (and 1 more)
Superseder		Nosy List	ganesh
Related Issues
Status	accepted	Assigned To
Milestone

Created on 2016-01-28.07:06:20 by ganesh, last changed 2016-02-04.17:46:59 by gh.

Files
File name	Status	Uploaded	Type	Edit	Remove
fix-tests-that-use-_git-commit_.dpatch		ganesh, 2016-01-28.07:06:20	application/x-darcs-patch
patch-preview.txt		ganesh, 2016-01-28.07:06:19	text/x-darcs-patch
unnamed		ganesh, 2016-01-28.07:06:20	text/plain

See mailing list archives for discussion on individual patches.

Messages
msg18986 (view)	Author: ganesh	Date: 2016-01-28.07:06:20
With these two patches, the git tests pass on my machine. 2 patches for repository darcs-unstable@darcs.net:screened: patch 085b2f05640faf353bbcf8c2bb1e758f7a716e0e Author: Ganesh Sittampalam <ganesh@earth.li> Date: Thu Jan 28 07:12:40 GMT 2016 * fix tests that use "git commit" On my machine (git 1.9.4) it seems all these variables need to be set to avoid git commit complaining about an "empty ident name". patch 5299873b33a9a11c3f8eae5851cdc1439c0939af Author: Ganesh Sittampalam <ganesh@earth.li> Date: Thu Jan 28 07:13:51 GMT 2016 * fix git test involving deletions There was a behaviour change in git 2, and git 1.9.4 requires '--all' to be passed to git add if you are deleting things. Attachments fix-tests-that-use-_git-commit_.dpatch patch-preview.txt unnamed
msg18987 (view)	Author: gh	Date: 2016-01-28.10:35:14
Thanks! These changes do not seem to break tests for me (using git 2.7). Accepted.
msg18993 (view)	Author: gh	Date: 2016-01-28.17:18:55
'fix tests that use "git commit"' applies cleany to branch 2.10 so I pushed it there. The other patch depends on patch that will not go in.

History
Date	User	Action	Args
2016-01-28 07:06:20	ganesh	create
2016-01-28 10:35:14	gh	set	status: needs-screening -> accepted messages: + msg18987
2016-01-28 10:40:29	gh	set	status: accepted -> accepted-pending-tests
2016-01-28 17:18:56	gh	set	messages: + msg18993
2016-02-04 17:46:59	gh	set	status: accepted-pending-tests -> accepted