darcs

Patch 1457 remove Storage.Hashed (and 4 more)

Title remove Storage.Hashed (and 4 more)
Superseder Nosy List gh
Related Issues
Status accepted Assigned To
Milestone

Created on 2016-03-01.21:01:52 by gh, last changed 2016-04-11.17:43:07 by gh.

Files
File name Status Uploaded Type Edit Remove
fix-compile-error-in-storage_hashed_test.dpatch gh, 2016-03-23.18:23:37 application/x-darcs-patch
patch-preview.txt gh, 2016-03-01.21:01:49 text/x-darcs-patch
patch-preview.txt gh, 2016-03-05.15:27:59 text/x-darcs-patch
patch-preview.txt gh, 2016-03-22.19:41:08 text/x-darcs-patch
patch-preview.txt gh, 2016-03-23.18:23:37 text/x-darcs-patch
patch-preview.txt gh, 2016-03-23.18:31:47 text/x-darcs-patch
put-copyright-headers-in-hashed_storage-modules.dpatch gh, 2016-03-05.15:27:59 application/x-darcs-patch
remove-storage_hashed.dpatch gh, 2016-03-01.21:01:49 application/x-darcs-patch
remove-unused-function-from-storage_hashed_plain.dpatch gh, 2016-03-23.18:31:47 application/x-darcs-patch
remove-unused-storage_hashed_packs.dpatch gh, 2016-03-22.19:41:08 application/x-darcs-patch
unnamed gh, 2016-03-01.21:01:49 text/plain
unnamed gh, 2016-03-05.15:27:59 text/plain
unnamed gh, 2016-03-22.19:41:08 text/plain
unnamed gh, 2016-03-23.18:23:37 text/plain
unnamed gh, 2016-03-23.18:31:47 text/plain
See mailing list archives for discussion on individual patches.
Messages
msg19043 (view) Author: gh Date: 2016-03-01.21:01:51
Further integrating hashed-storage code into Darcs.
There is a module Storage.Hashed.Packed that has
code unused in Darcs itself, I will see if I end
up merging the useful parts into Storage.Hashed.Darcs.

Also, it seems to me that Storage.Hashed is probably going
to end up in Darcs.Util . Opinions?

5 patches for repository http://darcs.net:

patch 6ae4191afc72fae4415962ded7c33b4435d79bea
Author: Guillaume Hoffmann <guillaumh@gmail.com>
Date:   Mon Feb 29 14:34:30 ART 2016
  * remove Storage.Hashed

patch a3da1aaba5610726589a2c760af4d1119b9f34db
Author: Guillaume Hoffmann <guillaumh@gmail.com>
Date:   Mon Feb 29 14:36:16 ART 2016
  * list and comment exports of Storage.Hashed.Darcs and Plain

patch d8bdb7eaab94a902e04382e299fe012ec6ff3c5f
Author: Guillaume Hoffmann <guillaumh@gmail.com>
Date:   Mon Feb 29 14:46:18 ART 2016
  * explicit exports for Storage.Hashed.Utils

patch 18c44de5d56bdb2f962f3e5fa7f200c85b4b7b42
Author: Guillaume Hoffmann <guillaumh@gmail.com>
Date:   Tue Mar  1 18:08:39 ART 2016
  * merge Storage.Hashed.AnchoredPath into Darcs.Util.Path

patch c0c1677360515f85821b8b8e66ffe7faee5bc4ce
Author: Guillaume Hoffmann <guillaumh@gmail.com>
Date:   Tue Mar  1 18:08:59 ART 2016
  * add Storage/Hashed dir to checkdeps contrib script
Attachments
msg19044 (view) Author: gh Date: 2016-03-05.15:27:59
2 patches for repository http://darcs.net:

patch e79dc2f062c0ae44f3edc35bc14fdd5c5dad58b7
Author: Guillaume Hoffmann <guillaumh@gmail.com>
Date:   Sat Mar  5 12:40:10 ART 2016
  * put copyright headers in hashed-storage modules

patch 631b92713f29f7047267f9a1cb1e46260f50f510
Author: Guillaume Hoffmann <guillaumh@gmail.com>
Date:   Sat Mar  5 12:40:46 ART 2016
  * rm hashed-storage changelog
Attachments
msg19058 (view) Author: bfrk Date: 2016-03-08.23:40:12
I have reservations about moving Storage.Hashed to Darcs.Util. There are
some practical disadvantages: longer module names and (even) deeper
nesting of modules tree. Also, the classification doesn't help much
(anything can be a "util"). What do we gain by moving it?
msg19063 (view) Author: gh Date: 2016-03-09.13:14:27
Hi Ben,

If the move occurred, we could at the same time change
"Storage.Hashed" to "HashedStorage" since "Storage" now contains no
files.

I think the gain would be that Darcs' code would still fall into the 4
existing categories: Util, Patch, Repository and UI.
Each category being aware only of the previous ones.

Currently with Storage.Hashed (or HashedStorage) living directly in
src/ , new developers would have trouble to know where it really
belongs and who uses it.

Guillaume
msg19110 (view) Author: gh Date: 2016-03-22.19:41:08
More work on removing unused or duplicate code from
Storage.Hashed.* .

7 patches for repository http://darcs.net:

patch 7e0c825bd6b64864152636e6c99d55d65c8b8b8b
Author: Guillaume Hoffmann <guillaumh@gmail.com>
Date:   Tue Mar 22 14:56:01 ART 2016
  * remove unused Storage.Hashed.Packs

patch 958aa18504780d96844f62b5925857d953bf8726
Author: Guillaume Hoffmann <guillaumh@gmail.com>
Date:   Tue Mar 22 14:56:13 ART 2016
  * reuse functions from Darcs.Util.Path

patch 2aa737c13ae9c41e5dcc938fc985b6e0f13c261b
Author: Guillaume Hoffmann <guillaumh@gmail.com>
Date:   Tue Mar 22 15:00:27 ART 2016
  * hlint Storage.Hashed.Darcs

patch 059701fb4e297195249771bf17d1d575da2edbf4
Author: Guillaume Hoffmann <guillaumh@gmail.com>
Date:   Tue Mar 22 15:21:39 ART 2016
  * remove unused functions from Storage.Hashed.Hash

patch d064b833f25b08151a6a1c07c1168d866944af5f
Author: Guillaume Hoffmann <guillaumh@gmail.com>
Date:   Tue Mar 22 15:53:20 ART 2016
  * removed unused or redundant functions from Storage.Hashed.Utils

patch 5cfb9511233afa6b125e20338f1281a1dcafa8a4
Author: Guillaume Hoffmann <guillaumh@gmail.com>
Date:   Tue Mar 22 16:46:45 ART 2016
  * move index-related functions from Utils to Index

patch cc35208c82e35b38a80e5215ab65eefa3063f7b6
Author: Guillaume Hoffmann <guillaumh@gmail.com>
Date:   Tue Mar 22 16:49:55 ART 2016
  * remove Storage.Hashed.Utils, move functions to Darcs.Utils.ByteString
Attachments
msg19111 (view) Author: gh Date: 2016-03-23.18:23:37
Oops, I accidentally removed an import during cleanup.

1 patch for repository http://darcs.net:

patch 2e8a070db32f7c2f51aa6692bd4881ca4d89c14e
Author: Guillaume Hoffmann <guillaumh@gmail.com>
Date:   Wed Mar 23 15:34:40 ART 2016
  * fix compile error in Storage.Hashed.Test
Attachments
msg19112 (view) Author: gh Date: 2016-03-23.18:31:47
With these, that should almost be it (except for tests).

In libdarcs, module hierarchy Storage.Hashed disappears
and gets merged into Darcs.Util as follows:

     ./src/Storage/Hashed/Hash.hs -> ./src/Darcs/Util/Hash.hs
     ./src/Storage/Hashed/Tree.hs -> ./src/Darcs/Util/Tree.hs
     ./src/Storage/Hashed/Darcs.hs -> ./src/Darcs/Util/Tree/Hashed.hs
     ./src/Storage/Hashed/Plain.hs -> ./src/Darcs/Util/Tree/Plain.hs
     ./src/Storage/Hashed/Monad.hs -> ./src/Darcs/Util/Tree/Monad.hs
     ./src/Storage/Hashed/Index.hs -> ./src/Darcs/Util/Index.hs

2 patches for repository http://darcs.net:

patch b20fc8b0a1e5894ad1e98a6110c58025d347692b
Author: Guillaume Hoffmann <guillaumh@gmail.com>
Date:   Tue Mar 22 18:39:32 ART 2016
  * remove unused function from Storage.Hashed.Plain

patch 66fd61b4dbc561ce4fe9cbcb7bfab6b9365dc24a
Author: Guillaume Hoffmann <guillaumh@gmail.com>
Date:   Wed Mar 23 15:45:01 ART 2016
  * move Storage.Hashed modules to Darcs.Util
Attachments
msg19158 (view) Author: gh Date: 2016-04-11.17:43:07
Self-accept also updated some doc on the wiki due to module names change.
History
Date User Action Args
2016-03-01 21:01:52ghcreate
2016-03-05 15:27:59ghsetfiles: + patch-preview.txt, put-copyright-headers-in-hashed_storage-modules.dpatch, unnamed
messages: + msg19044
2016-03-05 15:28:08ghsetstatus: needs-screening -> needs-review
2016-03-08 23:40:12bfrksetmessages: + msg19058
2016-03-09 13:14:28ghsetmessages: + msg19063
2016-03-22 19:41:09ghsetfiles: + patch-preview.txt, remove-unused-storage_hashed_packs.dpatch, unnamed
messages: + msg19110
2016-03-23 18:23:38ghsetfiles: + patch-preview.txt, fix-compile-error-in-storage_hashed_test.dpatch, unnamed
messages: + msg19111
2016-03-23 18:31:47ghsetfiles: + patch-preview.txt, remove-unused-function-from-storage_hashed_plain.dpatch, unnamed
messages: + msg19112
2016-04-11 17:43:07ghsetstatus: needs-review -> accepted
messages: + msg19158