darcs

Patch 1458 move runHLint.sh to root and update to run outside of ...

Title move runHLint.sh to root and update to run outside of ...
Superseder Nosy List gh
Related Issues
Status accepted Assigned To
Milestone

Created on 2016-03-05.20:00:59 by gh, last changed 2016-03-18.19:46:34 by gh.

Files
File name Status Uploaded Type Edit Remove
move-runhlint_sh-to-root-and-update-to-run-outside-of-testsuite.dpatch gh, 2016-03-05.20:00:59 application/x-darcs-patch
patch-preview.txt gh, 2016-03-05.20:00:59 text/x-darcs-patch
unnamed gh, 2016-03-05.20:00:59 text/plain
See mailing list archives for discussion on individual patches.
Messages
msg19045 (view) Author: gh Date: 2016-03-05.20:00:59
This patch does a few changes to improve our use of HLint and
avoid bitrot.

First it removes failing-haskell-policy.sh which cannot work because
tests are run in temporary directories, hence they have no access
to source code and cannot run HLint usefully.

As a consequence it also removes warnings silenciation from
contrib/darcs-errors.hlint, which were there since HLint was to
be run from the testsuite (in 2009 it seems).

Finally it removes Owen's HLint directory which is from 2012
and had bitrot.

We end up with two files: ./runHLint.sh and ./contrib/darcs-errors.hlint.

I hope that this will motivate us to run HLint on darcs' source code
more often. Things are currently not perfect; there is a bug in cpphs
that makes MIN_VERSION macros fail with hlint. Hence ./runHLint.sh
currently just ignores all CPP.

When we can assume we have sufficiently new cpphs, we can improve the
situation by changing how we use the MIN_VERSION macros, see
https://github.com/ndmitchell/hlint/issues/53 .

1 patch for repository http://darcs.net:

patch 78aa32b19683ac927703ca41e00621732ce043c4
Author: Guillaume Hoffmann <guillaumh@gmail.com>
Date:   Sat Mar  5 17:06:36 ART 2016
  * move runHLint.sh to root and update to run outside of testsuite
Attachments
msg19102 (view) Author: gh Date: 2016-03-18.19:46:34
Self-accept.
History
Date User Action Args
2016-03-05 20:01:00ghcreate
2016-03-05 20:01:38ghsetstatus: needs-screening -> needs-review
2016-03-18 19:46:34ghsetstatus: needs-review -> accepted
messages: + msg19102