darcs

Patch 1472 move copySources from HashedRepo to Clone (and 6 more)

Title move copySources from HashedRepo to Clone (and 6 more)
Superseder Nosy List gh
Related Issues
Status accepted Assigned To
Milestone

Created on 2016-03-25.21:40:08 by gh, last changed 2016-04-11.17:43:21 by gh.

Files
File name Status Uploaded Type Edit Remove
move-copysources-from-hashedrepo-to-clone.dpatch gh, 2016-03-25.21:40:07 application/x-darcs-patch
patch-preview.txt gh, 2016-03-25.21:40:07 text/x-darcs-patch
unnamed gh, 2016-03-25.21:40:07 text/plain
See mailing list archives for discussion on individual patches.
Messages
msg19115 (view) Author: gh Date: 2016-03-25.21:40:07
These refactorings aim at cleanup up Darcs.Repository.*,
in the sense that only modules that really are about
repositories should be there.

Back in 2012 when we started doing the separation of modules
in Darcs.Repository / Darcs.Patch there was no Darcs.Util at
first, so some modules ended up in Darcs.Repository, but there
was really no need for it. (Ssh, Lock, Compat and Extern).

Darcs.Repository.Read was added to avoid an import cycle from
Darcs.Repository.PatchIndex. But it occurs that patch index
building happens only in hashed repositories, so we can get
rid of this module.

7 patches for repository http://darcs.net:

patch 887dd0bbf0849db143ecdbdbc22b74d411897cae
Author: Guillaume Hoffmann <guillaumh@gmail.com>
Date:   Thu Mar 24 14:50:07 ART 2016
  * move copySources from HashedRepo to Clone

patch 935664ef7c4d55d00838e12db5ef764547aa06ed
Author: Guillaume Hoffmann <guillaumh@gmail.com>
Date:   Thu Mar 24 20:45:07 ART 2016
  * make all optimize subcommands require hashed except upgrade
  
  Almost all call internal functions that fail with
  old-fashionned repositories.

patch 55af973d3173e1bb13a85b06ea72c845e2d961a4
Author: Guillaume Hoffmann <guillaumh@gmail.com>
Date:   Thu Mar 24 20:47:19 ART 2016
  * add comments and remove checks of optimize commands wrt repo formats

patch 08cbe473f43d55098926431e4754d44f7b17915b
Author: Guillaume Hoffmann <guillaumh@gmail.com>
Date:   Fri Mar 25 13:11:10 ART 2016
  * remove Darcs.Repository.Read by moving readRepo back to Internal

patch 16e7843962930672bced76b61ce7bd47d0c8e03a
Author: Guillaume Hoffmann <guillaumh@gmail.com>
Date:   Fri Mar 25 15:36:10 ART 2016
  * merge Darcs.Repository.Ssh into Darcs.Util.Ssh

patch 0cc77b8acd89122a73a87e9a42a9903c54178d45
Author: Guillaume Hoffmann <guillaumh@gmail.com>
Date:   Fri Mar 25 16:03:31 ART 2016
  * move Compat and Lock modules from Repository to Util

patch 67729401747bf8ddb507c6a5243cbb36a495a115
Author: Guillaume Hoffmann <guillaumh@gmail.com>
Date:   Fri Mar 25 18:30:31 ART 2016
  * move External module from Repository to Util
Attachments
msg19159 (view) Author: gh Date: 2016-04-11.17:43:21
Self-accept.
History
Date User Action Args
2016-03-25 21:40:08ghcreate
2016-03-25 21:40:37ghsetstatus: needs-screening -> needs-review
2016-04-11 17:43:21ghsetstatus: needs-review -> accepted
messages: + msg19159