darcs

Patch 1499 resolve issue2496: improve output of darcs whatsnew with file arguments

Bug Tracker Home

Issues
Show Unassigned
 Show All
Search Issues

Patches
Show Open
 Show All
Search Patches

Login




Register
Lost your login?

Help
Roundup docs

Title resolve issue2496: improve output of darcs whatsnew with file arguments
Superseder Nosy List bfrk
Related Issues
Status accepted Assigned To
Milestone 2.12.0

Created on 2016-05-05.18:25:00 by bfrk, last changed 2016-09-01.17:29:06 by gh.

Files
File name Status Uploaded Type Edit Remove
fix-in-record_-use-only-existing-file-arguments-when-querying-patches.dpatch bfrk, 2016-05-05.18:25:00 application/x-darcs-patch
fix-in-record_-use-only-existing-file-arguments-when-querying-patches.dpatch bfrk, 2016-05-06.19:37:30 application/x-darcs-patch
patch-preview.txt bfrk, 2016-05-05.18:25:00 text/x-darcs-patch
patch-preview.txt bfrk, 2016-05-06.19:37:30 text/x-darcs-patch
unnamed bfrk, 2016-05-05.18:25:00 text/plain
unnamed bfrk, 2016-05-06.19:37:30 text/plain
See mailing list archives for discussion on individual patches.
Messages
msg19211 (view) Author: bfrk Date: 2016-05-05.18:25:00 
Sorry for the long delay in sending this patch I promised a while ago...

While looking at the changes I made for record I noticed a mistake I made:
when querying the patch sets (replacePs, movesPs, changes) we should only
take the filtered (existing) file arguments into account.

2 patches for repository http://darcs.net/screened:

patch 61630b1f1f2903367f6ca2329eb2d99954f8aaa8
Author: Ben Franksen <benjamin.franksen@helmholtz-berlin.de>
Date:   Thu May  5 20:14:46 CEST 2016
  * fix in record: use only existing file arguments when querying patches
  
  Also avoid future similar mistakes by taking the "files" and "files'"
  variables out of the scope of the rest of the procedure.

patch 8ae49fb4412e904cc316d63aae01ea8c2f924154
Author: Ben Franksen <benjamin.franksen@helmholtz-berlin.de>
Date:   Thu May  5 20:39:10 CEST 2016
  * resolve issue2496: improve output of darcs whatsnew with file arguments
Attachments
msg19216 (view) Author: bfrk Date: 2016-05-06.19:37:30 
Added a third patch that adds a regression test.

3 patches for repository http://darcs.net/screened:

patch 61630b1f1f2903367f6ca2329eb2d99954f8aaa8
Author: Ben Franksen <benjamin.franksen@helmholtz-berlin.de>
Date:   Thu May  5 20:14:46 CEST 2016
  * fix in record: use only existing file arguments when querying patches
  
  Also avoid future similar mistakes by taking the "files" and "files'"
  variables out of the scope of the rest of the procedure.

patch 8ae49fb4412e904cc316d63aae01ea8c2f924154
Author: Ben Franksen <benjamin.franksen@helmholtz-berlin.de>
Date:   Thu May  5 20:39:10 CEST 2016
  * resolve issue2496: improve output of darcs whatsnew with file arguments

patch 38a36b9bf41e96073f489a10cfc36f77e55b24ac
Author: Ben Franksen <benjamin.franksen@helmholtz-berlin.de>
Date:   Fri May  6 21:38:10 CEST 2016
  * added regression test for issue2496
Attachments
msg19247 (view) Author: gh Date: 2016-09-01.17:29:06 
Thanks Ben, I believe the fix and adding the feature to whatsnew is
worth it for version 2.12.1. Accepted.
History
Date User Action Args
2016-05-05 18:25:00bfrkcreate
2016-05-06 19:20:15bfrksettitle: fix in record: use only existing file ar... (and 1 more) -> resolve issue2496: improve output of darcs whatsnew with file arguments
2016-05-06 19:37:30bfrksetfiles: + patch-preview.txt, fix-in-record_-use-only-existing-file-arguments-when-querying-patches.dpatch, unnamed
messages: + msg19216
2016-05-06 20:26:37bfrksetstatus: needs-screening -> needs-review
2016-09-01 17:29:06ghsetstatus: needs-review -> accepted
messages: + msg19247
milestone: 2.12.0