darcs

Patch 1517 rename Darcs.Repository.HashedRepo to Da... (and 6 more)

Bug Tracker Home

Issues
Show Unassigned
 Show All
Search Issues

Patches
Show Open
 Show All
Search Patches

Login




Register
Lost your login?

Help
Roundup docs

Title rename Darcs.Repository.HashedRepo to Da... (and 6 more)
Superseder Nosy List gh
Related Issues
Status accepted Assigned To
Milestone 2.12.4

Created on 2016-09-27.16:35:58 by gh, last changed 2017-03-15.17:45:30 by bfrk.

Files
File name Status Uploaded Type Edit Remove
patch-preview.txt gh, 2016-09-27.16:35:57 text/x-darcs-patch
patch-preview.txt gh, 2016-09-29.17:03:29 text/x-darcs-patch
patch-preview.txt gh, 2016-09-29.21:02:23 text/x-darcs-patch
rename-darcs_repository_hashedrepo-to-darcs_repository_hashed.dpatch gh, 2016-09-27.16:35:57 application/x-darcs-patch
rename-darcs_repository_hashedrepo-to-darcs_repository_hashed.dpatch gh, 2016-09-29.17:03:29 application/x-darcs-patch
rename-darcs_repository_hashedrepo-to-darcs_repository_hashed.dpatch gh, 2016-09-29.21:02:23 application/x-darcs-patch
unnamed gh, 2016-09-27.16:35:57 text/plain
unnamed gh, 2016-09-29.17:03:29 text/plain
unnamed gh, 2016-09-29.21:02:23 text/plain
See mailing list archives for discussion on individual patches.
Messages
msg19291 (view) Author: gh Date: 2016-09-27.16:35:57 
This is a big refactoring of a few modules that live in
Darcs.Repository.*.

In summary, the idea is to end Darcs.Repository.Internal
as it is now. The main reason is because "Internal" is
a meaningless name. The topics covered by the "Internal"
module are actually:

* repository detection/finding
* pending-related functions
* merge/conflict-related functions
* working-copy-related functions
* hashed-related (pristine, inventory) functions

This bundle aims at organizing these topics into
separate modules. It only creates one new module, Working,
while it reuses others.

The patch I am less happy with is "move hashed related
functions from Internal to Hashed", mostly because it
makes several patch index-related functions require as
an argument the PatchSet of the repository (the PatchIndex
module can no longer call the readRepo function due to
a cycle). Maybe it is cleaner in a way.
Also, it's a big patch, maybe hard to review.

Opinions?

7 patches for repository http://darcs.net:

patch 107f00060c78c4cf5faacfe4d218f1f3e3b4db9b
Author: Guillaume Hoffmann <guillaumh@gmail.com>
Date:   Mon Sep 26 12:41:45 ART 2016
  * rename Darcs.Repository.HashedRepo to Darcs.Repository.Hashed

patch c903942b2d3e563e7ac7099df794dcf4dc09bf38
Author: Guillaume Hoffmann <guillaumh@gmail.com>
Date:   Mon Sep 26 15:29:08 ART 2016
  * move pending related functions from Internal to Pending

patch 8aaf8ab696e077e6d1a01800c99c6d400a3b75b8
Author: Guillaume Hoffmann <guillaumh@gmail.com>
Date:   Mon Sep 26 15:33:20 ART 2016
  * move merge related functions from Internal to Merge

patch 2e686da6e6bfad2ab1ee2becc8d5bb3fe87df3e1
Author: Guillaume Hoffmann <guillaumh@gmail.com>
Date:   Mon Sep 26 17:11:37 ART 2016
  * create Repository.Working

patch c80b331bcf3448801abee6a209bd61fc65797348
Author: Guillaume Hoffmann <guillaumh@gmail.com>
Date:   Mon Sep 26 17:17:13 ART 2016
  * move repoPatchType from Internal to InternalTypes

patch 38c35025a4810d5332d108ab910d2933ca4d3387
Author: Guillaume Hoffmann <guillaumh@gmail.com>
Date:   Tue Sep 27 12:46:18 ART 2016
  * move hashed related functions from Internal to Hashed

patch b32f3044a946992b9e87c8436971c42081d4a3cd
Author: Guillaume Hoffmann <guillaumh@gmail.com>
Date:   Tue Sep 27 13:01:23 ART 2016
  * rename Darcs.Repository.Internal to Darcs.Repository.Identify
Attachments
msg19293 (view) Author: gh Date: 2016-09-29.17:03:29 
Same bundle with a couple more cleanups.

11 patches for repository http://darcs.net:

patch 107f00060c78c4cf5faacfe4d218f1f3e3b4db9b
Author: Guillaume Hoffmann <guillaumh@gmail.com>
Date:   Mon Sep 26 12:41:45 ART 2016
  * rename Darcs.Repository.HashedRepo to Darcs.Repository.Hashed

patch c903942b2d3e563e7ac7099df794dcf4dc09bf38
Author: Guillaume Hoffmann <guillaumh@gmail.com>
Date:   Mon Sep 26 15:29:08 ART 2016
  * move pending related functions from Internal to Pending

patch 8aaf8ab696e077e6d1a01800c99c6d400a3b75b8
Author: Guillaume Hoffmann <guillaumh@gmail.com>
Date:   Mon Sep 26 15:33:20 ART 2016
  * move merge related functions from Internal to Merge

patch 2e686da6e6bfad2ab1ee2becc8d5bb3fe87df3e1
Author: Guillaume Hoffmann <guillaumh@gmail.com>
Date:   Mon Sep 26 17:11:37 ART 2016
  * create Repository.Working

patch c80b331bcf3448801abee6a209bd61fc65797348
Author: Guillaume Hoffmann <guillaumh@gmail.com>
Date:   Mon Sep 26 17:17:13 ART 2016
  * move repoPatchType from Internal to InternalTypes

patch 38c35025a4810d5332d108ab910d2933ca4d3387
Author: Guillaume Hoffmann <guillaumh@gmail.com>
Date:   Tue Sep 27 12:46:18 ART 2016
  * move hashed related functions from Internal to Hashed

patch b32f3044a946992b9e87c8436971c42081d4a3cd
Author: Guillaume Hoffmann <guillaumh@gmail.com>
Date:   Tue Sep 27 13:01:23 ART 2016
  * rename Darcs.Repository.Internal to Darcs.Repository.Identify

patch 046a74bceeb4dbb02baa6f6e20b3cb1d797ea5b2
Author: Guillaume Hoffmann <guillaumh@gmail.com>
Date:   Thu Sep 29 12:26:42 ART 2016
  * remove a few useless foralls

patch 756c54fa3c8194e415a7586686ab58ab4fe71690
Author: Guillaume Hoffmann <guillaumh@gmail.com>
Date:   Thu Sep 29 12:36:56 ART 2016
  * remove useless language extensions in Darcs.Repository modules

patch f935c1ec47c940cd38f6b228e7a149eb4d318902
Author: Guillaume Hoffmann <guillaumh@gmail.com>
Date:   Thu Sep 29 12:49:33 ART 2016
  * remove a useless forall in D.R.Pending

patch d5f7924d9e23c44fb8a188013f11c97d653fd993
Author: Guillaume Hoffmann <guillaumh@gmail.com>
Date:   Thu Sep 29 14:19:15 ART 2016
  * save lines in D.R.Hashed
Attachments
msg19294 (view) Author: gh Date: 2016-09-29.21:02:23 
12 patches for repository http://darcs.net:

patch 107f00060c78c4cf5faacfe4d218f1f3e3b4db9b
Author: Guillaume Hoffmann <guillaumh@gmail.com>
Date:   Mon Sep 26 12:41:45 ART 2016
  * rename Darcs.Repository.HashedRepo to Darcs.Repository.Hashed

patch c903942b2d3e563e7ac7099df794dcf4dc09bf38
Author: Guillaume Hoffmann <guillaumh@gmail.com>
Date:   Mon Sep 26 15:29:08 ART 2016
  * move pending related functions from Internal to Pending

patch 8aaf8ab696e077e6d1a01800c99c6d400a3b75b8
Author: Guillaume Hoffmann <guillaumh@gmail.com>
Date:   Mon Sep 26 15:33:20 ART 2016
  * move merge related functions from Internal to Merge

patch 2e686da6e6bfad2ab1ee2becc8d5bb3fe87df3e1
Author: Guillaume Hoffmann <guillaumh@gmail.com>
Date:   Mon Sep 26 17:11:37 ART 2016
  * create Repository.Working

patch c80b331bcf3448801abee6a209bd61fc65797348
Author: Guillaume Hoffmann <guillaumh@gmail.com>
Date:   Mon Sep 26 17:17:13 ART 2016
  * move repoPatchType from Internal to InternalTypes

patch 38c35025a4810d5332d108ab910d2933ca4d3387
Author: Guillaume Hoffmann <guillaumh@gmail.com>
Date:   Tue Sep 27 12:46:18 ART 2016
  * move hashed related functions from Internal to Hashed

patch b32f3044a946992b9e87c8436971c42081d4a3cd
Author: Guillaume Hoffmann <guillaumh@gmail.com>
Date:   Tue Sep 27 13:01:23 ART 2016
  * rename Darcs.Repository.Internal to Darcs.Repository.Identify

patch 046a74bceeb4dbb02baa6f6e20b3cb1d797ea5b2
Author: Guillaume Hoffmann <guillaumh@gmail.com>
Date:   Thu Sep 29 12:26:42 ART 2016
  * remove a few useless foralls

patch 756c54fa3c8194e415a7586686ab58ab4fe71690
Author: Guillaume Hoffmann <guillaumh@gmail.com>
Date:   Thu Sep 29 12:36:56 ART 2016
  * remove useless language extensions in Darcs.Repository modules

patch f935c1ec47c940cd38f6b228e7a149eb4d318902
Author: Guillaume Hoffmann <guillaumh@gmail.com>
Date:   Thu Sep 29 12:49:33 ART 2016
  * remove a useless forall in D.R.Pending

patch d5f7924d9e23c44fb8a188013f11c97d653fd993
Author: Guillaume Hoffmann <guillaumh@gmail.com>
Date:   Thu Sep 29 14:19:15 ART 2016
  * save lines in D.R.Hashed

patch 2e5945fac0afb3e22a55dd92506d8952b7213141
Author: Guillaume Hoffmann <guillaumh@gmail.com>
Date:   Thu Sep 29 18:31:57 ART 2016
  * introduce withOldRepoLock, reduce code specific to old-fashioned repos
Attachments
msg19299 (view) Author: gh Date: 2016-09-30.16:25:53 
Screened it.
msg19368 (view) Author: bfrk Date: 2017-03-15.17:45:30 
I haven't looked at all these changes in detail but I am convinced that
the result is more sane than what was there before! Besides I am working
with screened all the time and noticed no problems.
History
Date User Action Args
2016-09-27 16:35:58ghcreate
2016-09-29 17:03:30ghsetfiles: + patch-preview.txt, rename-darcs_repository_hashedrepo-to-darcs_repository_hashed.dpatch, unnamed
messages: + msg19293
2016-09-29 21:02:23ghsetfiles: + patch-preview.txt, rename-darcs_repository_hashedrepo-to-darcs_repository_hashed.dpatch, unnamed
messages: + msg19294
2016-09-30 16:25:54ghsetstatus: needs-screening -> needs-review
messages: + msg19299
2017-03-15 17:45:30bfrksetstatus: needs-review -> accepted
messages: + msg19368
milestone: 2.12.4