darcs

Patch 1523 resolve issue2516: joining (possible) URL path element...

Title resolve issue2516: joining (possible) URL path element...
Superseder Nosy List bf
Related Issues
Status accepted Assigned To
Milestone 2.12.5 STABLE

Created on 2016-12-20.20:07:54 by bf, last changed 2017-01-11.06:15:24 by ganesh.

Files
File name Status Uploaded Type Edit Remove
patch-preview.txt bf, 2016-12-20.20:07:53 text/x-darcs-patch
resolve-issue2516_-joining-_possible_-url-path-elements-should-not-use-___-from-system_filepath.dpatch bf, 2016-12-20.20:07:53 application/x-darcs-patch
unnamed bf, 2016-12-20.20:07:53 text/plain
See mailing list archives for discussion on individual patches.
Messages
msg19326 (view) Author: bf Date: 2016-12-20.20:07:53
Added function joinUrl to join the URL segments. This has mostly documentary
purpose, so as to avoid making a mistake like this again. The function can
be moved to a Util module if it turns out to be useful in other places.

1 patch for repository http://darcs.net/screened:

patch a258461992333257525a918db516100777ca5e9f
Author: Ben Franksen <benjamin.franksen@helmholtz-berlin.de>
Date:   Tue Dec 20 21:41:22 CET 2016
  * resolve issue2516: joining (possible) URL path elements should not use </> from System.FilePath
Attachments
msg19340 (view) Author: ganesh Date: 2017-01-10.22:32:40
Looks good to me, I'll double-check on Windows then accept this. It can 
also go into 2.12.5.
History
Date User Action Args
2016-12-20 20:07:54bfcreate
2017-01-08 20:04:07bfsetstatus: needs-screening -> needs-review
2017-01-10 22:32:40ganeshsetstatus: needs-review -> accepted-pending-tests
messages: + msg19340
2017-01-10 22:32:46ganeshsetmilestone: 2.12.0
2017-01-10 22:34:47ganeshsetmilestone: 2.12.0 -> 2.12.5 STABLE
2017-01-11 06:15:24ganeshsetstatus: accepted-pending-tests -> accepted