1 patch for repository valentina:var/repos/darcs/screened:

patch 6047f02180470b5048e7128e979be8200bd153ac
Author: Gian Piero Carrubba <gpiero@rm-rf.it>
Date:   Wed Mar  8 14:25:48 CET 2017
  * Accept issue2275: darcs follows symbolic links instead of ignoring them

Attachments

• accept-issue2275_-darcs-follows-symbolic-links-instead-of-ignoring-them.dpatch
• patch-preview.txt

I have screened this patch. I do think this needs a bit more discussion
wrt the intended behavior, see my remarks re issue2275, but I would like
to see this resolved.

bf, whats's next for this patch? I see there was some more discussion in 
issue2275, but I didn't read it in detail. Does this failing test specify 
behaviour we want?

The test captures parts of the requirement: the symbolic link should be
ignored and *not* resolved. But I maintain that Darcs should issue a
warning. There are two cases to consider:

(1) a symlink with a name that collides with a known file or directory
(known = in recorded or pending)

(2) a symlink that targets a known file or directory

In case (1) I think it would be wrong to "ignore the symlink" as that
would mean the file or directory is regarded as deleted. This would be
very surprising. One might even make this an error ("error: linkname has
been replaced with symbolic link to linktarget").

Case (2) is slightly more benign, but I would still want a warning
(something like "warning: ignoring symbolic link linkname -> linktarget").

Variants could include asking the user how to proceed (resolve, ignore,
terminate).

OK, so I'll accept this patch and the test case can be improved later to 
check for a future warning too.