Patch 1534 Include the weak hash in the output of --exact-version

Title Include the weak hash in the output of --exact-version
Superseder Nosy List gpiero
Related Issues
Status accepted Assigned To

Created on 2017-03-09.14:56:40 by gpiero, last changed 2018-02-16.17:45:43 by gh.

File name Status Uploaded Type Edit Remove
include-the-weak-hash-in-the-output-of-__exact_version.dpatch gpiero, 2018-01-06.07:08:50 application/octet-stream
See mailing list archives for discussion on individual patches.
msg19358 (view) Author: gpiero Date: 2017-03-09.14:56:38
Thought it was a good idea to include the weak hash for bug reports.
On second thought, anyway, it probably doesn't add much value. I'm going to
leave the decision to whoever is screening this.

1 patch for repository valentina:var/repos/darcs/screened:

patch a48139fef50e583b7d029b6b875f718c30b7588c
Author: Gian Piero Carrubba <gpiero@rm-rf.it>
Date:   Thu Mar  9 14:59:15 CET 2017
  * Include the weak hash in the output of --exact-version
msg19359 (view) Author: gpiero Date: 2017-03-10.15:25:55
* [Thu, Mar 09, 2017 at 02:56:40PM +0000] Gian Piero Carrubba:
>1 patch for repository valentina:var/repos/darcs/screened:
>patch a48139fef50e583b7d029b6b875f718c30b7588c
>Author: Gian Piero Carrubba <gpiero@rm-rf.it>
>Date:   Thu Mar  9 14:59:15 CET 2017
>  * Include the weak hash in the output of --exact-version

Please don't accept it, it causes cabal haddock to fail with:

darcs: runInteractiveProcess: runInteractiveProcess: exec: does not 
exist (No such file or directory)

Gian Piero.
msg19360 (view) Author: ganesh Date: 2017-03-12.09:52:49
Marking as rejected as requested, feel free to update the status or just 
open a new patch if you want to follow up.
msg19815 (view) Author: gpiero Date: 2018-01-06.07:08:48
Fixed version.
msg19825 (view) Author: bf Date: 2018-01-21.17:31:51
Good idea, screening it.
msg19892 (view) Author: gh Date: 2018-02-16.17:45:42
I have mixed feelings. I don't think this is very useful right now. The
weak hash gives us less information than the full context, and  we
currently lack a mechanism to retrieve a context from a weak hash,
althought we may have one in the future.

On the other hand the implementation of this feature is harmless.

So, I'm accepting it, I must say, mostly because it has already been
screened. Maybe next time, please share the reasons *why* adding some
feature is a good idea :)
Date User Action Args
2017-03-09 14:56:40gpierocreate
2017-03-10 15:25:57gpierosetmessages: + msg19359
2017-03-12 09:52:50ganeshsetstatus: needs-screening -> rejected
messages: + msg19360
2018-01-06 07:06:58gpierosetfiles: - include-the-weak-hash-in-the-output-of-__exact_version.dpatch
2018-01-06 07:07:07gpierosetfiles: - patch-preview.txt
2018-01-06 07:08:50gpierosetstatus: rejected -> needs-screening
files: + include-the-weak-hash-in-the-output-of-__exact_version.dpatch
messages: + msg19815
2018-01-21 17:31:51bfsetstatus: needs-screening -> needs-review
messages: + msg19825
2018-02-16 17:45:43ghsetstatus: needs-review -> accepted
messages: + msg19892