Patch 1536: resolve issue2526: actually consider boring option in ... - Darcs bug tracker

Title	resolve issue2526: actually consider boring option in ...
Superseder		Nosy List	bfrk
Related Issues
Status	accepted	Assigned To
Milestone

Created on 2017-03-15.14:24:45 by bfrk, last changed 2017-03-20.05:09:46 by ganesh.

Files
File name	Status	Uploaded	Type	Edit	Remove
patch-preview.txt		bfrk, 2017-03-15.14:24:45	text/x-darcs-patch
resolve-issue2526_-actually-consider-boring-option-in-d_ui_flags_diffingopts.dpatch		bfrk, 2017-03-15.14:24:45	application/x-darcs-patch
unnamed		bfrk, 2017-03-15.14:24:45	text/plain

See mailing list archives for discussion on individual patches.

Messages
msg19364 (view)	Author: bfrk	Date: 2017-03-15.14:24:45
With this patch all tests pass (again). 1 patch for repository http://darcs.net/screened: patch f10c0cdcf6beb1c29607e16de0ca9fd7169c833c Author: Ben Franksen <benjamin.franksen@helmholtz-berlin.de> Date: Wed Mar 15 17:08:45 CET 2017 * resolve issue2526: actually consider boring option in D.UI.Flags.diffingOpts Attachments patch-preview.txt resolve-issue2526_-actually-consider-boring-option-in-d_ui_flags_diffingopts.dpatch unnamed
msg19382 (view)	Author: ganesh	Date: 2017-03-20.05:09:46
Looks good. A minor note about adding tests when fixing bugs - it's slightly nicer if your first patch adds a "failing" test, then the second fixes the bug and renames the failing test. That way people bisecting in future for test breakage won't accidentally hit the intermediate state, but it's still easy to check that the test failed before the fix and passes after it.

History
Date	User	Action	Args
2017-03-15 14:24:45	bfrk	create
2017-03-15 15:37:38	bfrk	set	status: needs-screening -> needs-review
2017-03-20 05:09:46	ganesh	set	status: needs-review -> accepted messages: + msg19382