darcs

Patch 1537 remove umask and update_working paramete... (and 2 more)

Title remove umask and update_working paramete... (and 2 more)
Superseder Nosy List bf
Related Issues
Status obsoleted Assigned To
Milestone

Created on 2017-03-19.20:59:50 by bf, last changed 2017-03-19.21:02:11 by bf.

Files
File name Status Uploaded Type Edit Remove
patch-preview.txt bf, 2017-03-19.20:59:49 text/x-darcs-patch
remove-umask-and-update_working-parameters-from-withrepolockcanfail.dpatch bf, 2017-03-19.20:59:49 application/x-darcs-patch
unnamed bf, 2017-03-19.20:59:49 text/plain
See mailing list archives for discussion on individual patches.
Messages
msg19379 (view) Author: bf Date: 2017-03-19.20:59:50
3 patches for repository http://darcs.net/screened:

patch 60112ae92feb318a8a82901b1f865771447a82bb
Author: Ben Franksen <benjamin.franksen@helmholtz-berlin.de>
Date:   Sun Mar 19 21:20:04 CET 2017
  * remove umask and update_working parameters from withRepoLockCanFail
  
  This entry point is currently only used for attemptCreatePatchIndex. I added
  documentation to withRepoLockCanFail that makes it clear that neither
  pending nor pending.tentative should be touched by the job, making the call
  to revertRepositoryChanges unnecessary.
  
  BTW, the passed umask setting was a fake anyway: of both commands
  that use withRepoLockCanFail (log and annotate), none actually has the
  --umask switch (and rightly so, since the user doesn't expect them to write
  any files) so we always get the default NoUMask.

patch 94060dc3db84dc3fe53648ed96820d4ec12fb198
Author: Ben Franksen <benjamin.franksen@helmholtz-berlin.de>
Date:   Sun Mar 19 20:22:40 CET 2017
  * use a config record in annotate command

patch 5df61005451b62da1142d9ac5c04b9ec9d44e317
Author: Ben Franksen <benjamin.franksen@helmholtz-berlin.de>
Date:   Sun Mar 19 23:43:26 CET 2017
  * tests/log.sh: run tests in separate dirs and don't remove them
  
  This change makes it easier to find out what went wrong when the test fails.
Attachments
msg19380 (view) Author: bf Date: 2017-03-19.21:02:11
forgot to add another patch
History
Date User Action Args
2017-03-19 20:59:50bfcreate
2017-03-19 21:02:11bfsetstatus: needs-screening -> obsoleted
messages: + msg19380