darcs

Patch 1553 refactored repair/check command

Title refactored repair/check command
Superseder Nosy List bf
Related Issues
Status accepted Assigned To
Milestone

Created on 2017-04-06.16:18:04 by bf, last changed 2017-04-17.12:41:16 by ganesh.

Files
File name Status Uploaded Type Edit Remove
patch-preview.txt bf, 2017-04-06.16:18:04 text/x-darcs-patch
refactored-repair_check-command.dpatch bf, 2017-04-06.16:18:04 application/x-darcs-patch
unnamed bf, 2017-04-06.16:18:04 text/plain
See mailing list archives for discussion on individual patches.
Messages
msg19433 (view) Author: bf Date: 2017-04-06.16:18:04
Sorry for missing patch bundle in the tracker. Here it is:

1 patch for repository /home/ben/src/darcs/clean:

patch 3648c58a3bb446cf5a12887abc690d704ac3f053
Author: Ben Franksen <benjamin.franksen@helmholtz-berlin.de>
Date:   Thu Mar 23 14:44:02 CET 2017
  * refactored repair/check command
  
  - remove explicit manipulations of flag list
  - remove useless dryRun and umask options from check
  - revert check back to a normal (hidden) command but re-use code where
    appropriate
  - make option definitions local to command definitions unless shared between
    commands (avoids type signatures that are useless and detrimental to
    refactorings)
  - cleanup of code layout, including import and export lists
Attachments
msg19445 (view) Author: ganesh Date: 2017-04-16.18:27:31
Looks good. I like having 'check' back.
History
Date User Action Args
2017-04-06 16:18:05bfcreate
2017-04-06 16:18:41bfsetstatus: needs-screening -> needs-review
2017-04-16 18:27:32ganeshsetstatus: needs-review -> accepted-pending-tests
messages: + msg19445
2017-04-17 12:41:16ganeshsetstatus: accepted-pending-tests -> accepted