After the last refactoring, show repo does not accept '--no-files' anymore as
a way to perform the command in O(1). This has an impact on some hook scripts
of mine that invoke darcs show repo just for getting the repodir.
On the 4/5-years-old low-end (but with ssd) laptop I'm writing this on, the
show repo on darcs screened is now ~600ms instead of ~30ms:
$ time darcs show repo >/dev/null
$ time darcs show repo --no-enum-patches >/dev/null
While it doesn't seem a great difference (and it isn't in general) this means
my hook script went from almost-no-delay to noticeable-delay.
Apart from the questionable name of the option, I'm asking for opinion about
the content of the patch itself: I've tried to conform to the recent (in
progress) refactoring (namely the use of YesNo types) but I'm not sure got it
correctly as I've ended up with a patch that seems unnecessarily convoluted.
1 patch for repository valentina:var/repos/darcs/screened:
Author: Gian Piero Carrubba <email@example.com>
Date: Wed Apr 19 18:49:32 CEST 2017
* Add '--[no-]enum-patches' to show repo
for displaying patches count and weak hash (enabled by default).
This is intended for executing show repo in O(1) when that data
is not needed.
Thanks, the patch is perfectly fine. The name --enum-patches may not be
perfect but it's not so bad either. Thanks for taking the time to update
the help text and for giving a good description for the option.
I'll accept as soon as its dependencies are accepted.
status: needs-screening -> review-in-progress messages:
+ msg19474 title: Add '-- -> Add --[no-]enum-patches to show repo