darcs

Patch 1563 haddock and cleanups in patch-index code

Title haddock and cleanups in patch-index code
Superseder Nosy List gh
Related Issues
Status accepted Assigned To
Milestone

Created on 2017-08-08.15:22:20 by gh, last changed 2017-08-12.12:24:11 by bf.

Files
File name Status Uploaded Type Edit Remove
haddock-and-cleanups-in-patch_index-code.dpatch gh, 2017-08-08.15:22:19 application/octet-stream
See mailing list archives for discussion on individual patches.
Messages
msg19511 (view) Author: gh Date: 2017-08-08.15:22:19
This is a mix of haddock Darcs.Repository.PatchIndex, weeding (little)
code that is not actually used elsewhere, reordering function
definitions so that they lie close to where they are used.

Also, the two functions used by "darcs show patch-index" are clearly
made read-only (do not attempt to update patch-index if out-of-sync),
which simplifies them.
Attachments
msg19555 (view) Author: bf Date: 2017-08-12.10:28:52
Looks good to me. The docs are greatly improved. Several functions that
are used only once have been inlined or made local to the using
function. In a few places unneeded arguments or results have been elided.

Just a remark, since this patch is not responsible for it: IMO the code
layout of src/darcs/clean/src/Darcs/Repository/PatchIndex.hs could be
further improved by breaking the many over-long lines (over 130
characters). They make viewing diffs side by side difficult unless you
have two monitors (and don't use xmonad).
msg19556 (view) Author: bf Date: 2017-08-12.10:33:12
I just saw that this patch depends on 'get rid of almost all flag list
hacking', which is not yet in reviewed. What is the procedure in this
case? Should I revert 'accepted' to 'review-in-progress'?
msg19560 (view) Author: bf Date: 2017-08-12.12:24:11
My mistake: forgot to pull from reviewed.
History
Date User Action Args
2017-08-08 15:22:20ghcreate
2017-08-12 10:28:53bfsetstatus: needs-review -> accepted
messages: + msg19555
2017-08-12 10:33:13bfsetmessages: + msg19556
2017-08-12 11:23:56bfsetstatus: accepted -> review-in-progress
2017-08-12 12:24:11bfsetstatus: review-in-progress -> accepted
messages: + msg19560