Patch 1564: move packs creation code to Darcs.Repository.Packs - Darcs bug tracker

Title	move packs creation code to Darcs.Repository.Packs
Superseder		Nosy List	gh
Related Issues
Status	accepted	Assigned To
Milestone

Created on 2017-08-08.19:18:37 by gh, last changed 2017-08-12.11:42:16 by bfrk.

Files
File name	Status	Uploaded	Type	Edit	Remove
fix-packs-creation-in-repositories-without-_darcs_packs.dpatch		gh, 2017-08-09.16:25:22	application/octet-stream
move-packs-creation-code-to-darcs_repository_packs.dpatch		gh, 2017-08-08.19:18:36	application/octet-stream

See mailing list archives for discussion on individual patches.

Messages
msg19513 (view)	Author: gh	Date: 2017-08-08.19:18:36
This patch moves non-UI code where it should really belong. Darcs.UI.Commands.Optimize.doHttpOptimize is moved to Darcs.Repository.Packs.createPacks . I believe darcsden should be updated accordingly. Attachments move-packs-creation-code-to-darcs_repository_packs.dpatch
msg19524 (view)	Author: bfrk	Date: 2017-08-09.13:15:11
With an up-to-date screened, the tests network//clone-http-packed* fail. I haven't checked that it is this patch that causes the problem, it's just a guess...
msg19525 (view)	Author: bfrk	Date: 2017-08-09.13:17:04
The failure message is: \| + darcs optimize http \| darcs: _darcs/packs/patches.tar.gz.part: openBinaryFile: does not exist (No such file or directory)
msg19534 (view)	Author: gh	Date: 2017-08-09.16:25:22
My bad! I'm screening the fix. I got entangled with paths when moving this piece of code. Attachments fix-packs-creation-in-repositories-without-_darcs_packs.dpatch
msg19558 (view)	Author: bfrk	Date: 2017-08-12.11:42:15
Looks good to me (with the fix). Not mentioned in the description: improved haddocks for D.R.Packs, renamed doOptimizeHTTP to createPacks. Both are very much appreciated.

History
Date	User	Action	Args
2017-08-08 19:18:37	gh	create
2017-08-09 13:15:12	bfrk	set	messages: + msg19524
2017-08-09 13:17:04	bfrk	set	messages: + msg19525
2017-08-09 16:25:22	gh	set	files: + fix-packs-creation-in-repositories-without-_darcs_packs.dpatch messages: + msg19534
2017-08-12 11:42:16	bfrk	set	status: needs-review -> accepted messages: + msg19558