darcs

Patch 1564 move packs creation code to Darcs.Repository.Packs

Title move packs creation code to Darcs.Repository.Packs
Superseder Nosy List gh
Related Issues
Status accepted Assigned To
Milestone

Created on 2017-08-08.19:18:37 by gh, last changed 2017-08-12.11:42:16 by bf.

Files
File name Status Uploaded Type Edit Remove
fix-packs-creation-in-repositories-without-_darcs_packs.dpatch gh, 2017-08-09.16:25:22 application/octet-stream
move-packs-creation-code-to-darcs_repository_packs.dpatch gh, 2017-08-08.19:18:36 application/octet-stream
See mailing list archives for discussion on individual patches.
Messages
msg19513 (view) Author: gh Date: 2017-08-08.19:18:36
This patch moves non-UI code where it should really belong.

Darcs.UI.Commands.Optimize.doHttpOptimize is moved to
Darcs.Repository.Packs.createPacks . I believe darcsden
should be updated accordingly.
Attachments
msg19524 (view) Author: bf Date: 2017-08-09.13:15:11
With an up-to-date screened, the tests network//clone-http-packed* fail.

I haven't checked that it is this patch that causes the problem, it's
just a guess...
msg19525 (view) Author: bf Date: 2017-08-09.13:17:04
The failure message is:

| + darcs optimize http
| darcs: _darcs/packs/patches.tar.gz.part: openBinaryFile: does not
exist (No such file or directory)
msg19534 (view) Author: gh Date: 2017-08-09.16:25:22
My bad! I'm screening the fix. I got entangled with paths when moving
this piece of code.
Attachments
msg19558 (view) Author: bf Date: 2017-08-12.11:42:15
Looks good to me (with the fix). Not mentioned in the description:
improved haddocks for D.R.Packs, renamed doOptimizeHTTP to createPacks.
Both are very much appreciated.
History
Date User Action Args
2017-08-08 19:18:37ghcreate
2017-08-09 13:15:12bfsetmessages: + msg19524
2017-08-09 13:17:04bfsetmessages: + msg19525
2017-08-09 16:25:22ghsetfiles: + fix-packs-creation-in-repositories-without-_darcs_packs.dpatch
messages: + msg19534
2017-08-12 11:42:16bfsetstatus: needs-review -> accepted
messages: + msg19558