Patch 1569 add trailing slash to local dir when cloning over ssh

Title add trailing slash to local dir when cloning over ssh
Superseder Nosy List bf
Related Issues
Status needs-review Assigned To

Created on 2017-08-09.11:26:43 by bf, last changed 2017-08-19.09:18:38 by bf.

File name Status Uploaded Type Edit Remove
add-trailing-slash-to-local-dir-when-cloning-over-ssh.dpatch bf, 2017-08-09.11:26:42 text/x-darcs-patch
fix-cloning-to-ssh-without-specifying-destination-directory.dpatch gh, 2017-08-18.21:09:14 application/octet-stream
See mailing list archives for discussion on individual patches.
msg19518 (view) Author: bf Date: 2017-08-09.11:26:42
1 patch for repository http://darcs.net/screened:

patch a4e18b91089292dc6c7eba74e7106bb805aa511a
Author: Ben Franksen <ben.franksen@online.de>
Date:   Tue May 16 08:33:59 CEST 2017
  * add trailing slash to local dir when cloning over ssh
  This change makes it possible to use DARCS_SCP=rsync which can be much
  faster than scp. Without trailing slash on the source dir, rsync
creates the
  local dir inside the target dir which is not what we want here.
Behavior of
  scp is not affected by this change.
msg19607 (view) Author: gh Date: 2017-08-18.21:09:14
This looks good (according to
https://codeyarns.com/2016/10/01/trailing-slash-in-rsync/ for instance.)

I'm attaching another patch that fixes a corner case where one does not
specify tyhe destination directory. Without this patch, the directory
created is "local". Now, it is the name of the current directory.
msg19610 (view) Author: bf Date: 2017-08-19.09:18:37
Unfortunately in this corner case rsync and scp behave differently,
regardless of whether a slash is appended to the target: rsync creates
the repo directly in the home directory, whereas scp creates it in a
subdir. I will think about how to work around that so that the behavior
will be the same in all cases.
Date User Action Args
2017-08-09 11:26:43bfcreate
2017-08-09 11:27:49bfsetstatus: needs-screening -> needs-review
2017-08-18 21:09:15ghsetfiles: + fix-cloning-to-ssh-without-specifying-destination-directory.dpatch
messages: + msg19607
2017-08-19 09:18:38bfsetmessages: + msg19610