darcs

Patch 1579 resolve issue2531: help for non-existing subcommand should fail

Title resolve issue2531: help for non-existing subcommand should fail
Superseder Nosy List
Related Issues
Status accepted Assigned To
Milestone

Created on 2017-08-12.15:13:52 by bfrk, last changed 2018-02-07.23:18:34 by gh.

Files
File name Status Uploaded Type Edit Remove
resolve-issue2531_-help-for-non_existing-subcommand-should-fail.dpatch bfrk, 2017-08-12.15:13:52 application/x-darcs-patch
See mailing list archives for discussion on individual patches.
Messages
msg19614 (view) Author: gh Date: 2017-08-20.15:17:21
This works for "darcs show patchindex --help" (but showing a one-line
error message before showing the help of darcs show), but not for "darcs
help show patchindex".  Can you also fix the second case?
msg19623 (view) Author: bfrk Date: 2017-08-21.09:13:15
Are you sure? I get the same result for both. In fact, I think the
--help already filed as expected before this patch and all I did was to
bring the help command on par with --help. I should add a test to make sure.
msg19627 (view) Author: bfrk Date: 2017-08-25.06:58:25
s/filed/failed/

Sorry, my laptop lately acquired a problem with the 'a' key...
msg19851 (view) Author: gh Date: 2018-02-07.23:18:34
I just tried again and I was wrong, this works in both cases! Accepted
(it was already in the reviewed branch anyway).
History
Date User Action Args
2017-08-12 15:13:52bfrkcreate
2017-08-12 15:14:43bfrksetstatus: needs-screening -> needs-review
2017-08-20 15:17:21ghsetmessages: + msg19614
2017-08-21 09:13:15bfrksetmessages: + msg19623
2017-08-25 06:58:25bfrksetmessages: + msg19627
2018-02-07 23:18:34ghsetstatus: needs-review -> accepted
messages: + msg19851