darcs

Patch 1592 refactor text encoding in darcs (rebased from Ben's encoding branch)

Title refactor text encoding in darcs (rebased from Ben's encoding branch)
Superseder Nosy List bf, gh
Related Issues
Status accepted Assigned To
Milestone

Created on 2017-08-26.21:15:12 by gh, last changed 2017-09-09.23:41:31 by gh.

Files
File name Status Uploaded Type Edit Remove
fix-warnings-and-unused-imports-in-setup_hs.dpatch gh, 2017-08-26.22:34:22 application/octet-stream
refactor-text-encoding-in-darcs.dpatch gh, 2017-08-26.21:15:11 application/octet-stream
See mailing list archives for discussion on individual patches.
Messages
msg19630 (view) Author: gh Date: 2017-08-26.21:15:11
7 patches manually rebased from Ben's encoding branch [1] 

This is not a strict rebase, since I already pushed parts of the first
patch "refactor text encoding" as 7 small patches [2], and removed some
comments hunks from "refactor text encoding" and the change in the help
of `darcs apply` that was unrelated.

Also in the patch "removed no longer needed iconv bindings" I added
hunks to remove iconv-related code from Setup.hs.

One patch I left out is "clean up display of file names by separating
display and storage of patches". Since with the current patches,all
tests pass, I think this last patch can come in a separate patch bundle.
(Also I haven't rebased it yet.)


[1] https://lists.osuosl.org/pipermail/darcs-devel/2017-May/018016.html
[2] http://bugs.darcs.net/patch1591
Attachments
msg19631 (view) Author: gh Date: 2017-08-26.22:34:22
Incidentally, cleaning unused imports makes it work with both Cabal 1.24
and 2.0.
Attachments
msg19654 (view) Author: gh Date: 2017-09-09.23:41:31
I'm accepting this bundle. I cannot say for sure that it solves
everything in the best of all ways (eg the use of knob), but it works,
and simplifies a lot of things. Great job :D
History
Date User Action Args
2017-08-26 21:15:12ghcreate
2017-08-26 22:34:22ghsetfiles: + fix-warnings-and-unused-imports-in-setup_hs.dpatch
messages: + msg19631
2017-09-09 23:41:31ghsetstatus: needs-review -> accepted
messages: + msg19654