darcs

Patch 1604 cleanups and tests related to bytestring and encoding (8 patches)

Title cleanups and tests related to bytestring and encoding (8 patches)
Superseder Nosy List bf
Related Issues
Status accepted Assigned To
Milestone

Created on 2017-10-02.17:28:34 by bf, last changed 2017-10-09.15:08:05 by gh.

Files
File name Status Uploaded Type Edit Remove
consistently-renamed-module-aliases-for-bytestring-variants.dpatch bf, 2017-10-02.17:28:33 application/x-darcs-patch
See mailing list archives for discussion on individual patches.
Messages
msg19683 (view) Author: bf Date: 2017-10-02.17:28:33
8 patches for repository http://darcs.net/screened:

patch e1286c3c2fd8696be5005992053f8ad6147e954a
Author: Ben Franksen <ben.franksen@online.de>
Date:   Mon Sep 25 09:31:41 CEST 2017
  * consistently renamed module aliases for ByteString variants
  
  We now always import qualified:
  Data.ByteString as B
  Data.ByteString.Lazy as BL
  Data.ByteString.Char8 as BC
  Data.ByteString.Lazy.Char8 as BLC

patch 78def60e2ca8e8bfc106e11e01eb4c9434179024
Author: Ben Franksen <ben.franksen@online.de>
Date:   Mon Sep 25 10:08:34 CEST 2017
  * replace ByteString.*Char8 with plain ByteString where Char8 is not
needed

patch cfe0d6a6b50b336bcd3dbd2366184d10f8287799
Author: Ben Franksen <ben.franksen@online.de>
Date:   Tue Sep 26 12:08:04 CEST 2017
  * extended tests/issue2286-metadata-encoding.sh

patch aadea1646dd9f81dec34d3e05eef92f9a591b0c6
Author: Ben Franksen <ben.franksen@online.de>
Date:   Tue Sep 26 12:13:26 CEST 2017
  * added a comment to instance Arbitrary UnicodeString

patch 88a95f0321acf1cb4290d7d341e3676ff1958705
Author: Ben Franksen <ben.franksen@online.de>
Date:   Tue Sep 26 12:15:06 CEST 2017
  * reduce use of BC to where it is needed

patch f5a9316f89ff3403a21a95e86f2a4eb36193217d
Author: Ben Franksen <benjamin.franksen@helmholtz-berlin.de>
Date:   Wed Sep 27 18:30:06 CEST 2017
  * renamed test for issue2480 because it no longer fails

patch f884c45ef84ddc73b7e514add1a789293e6dd181
Author: Ben Franksen <benjamin.franksen@helmholtz-berlin.de>
Date:   Wed Sep 27 18:38:44 CEST 2017
  * add a test that shows issue2262 has been resolved

patch 2ebde5037fa50c06afde0abd196d7a432fd121c7
Author: Ben Franksen <ben.franksen@online.de>
Date:   Mon Oct  2 14:52:46 CEST 2017
  * test harness: simplify instance Arbitrary ByteString
Attachments
msg19711 (view) Author: gh Date: 2017-10-09.15:08:04
All these changes look correct to me. At last we have consistent aliases
for Bytestring variants across all Darcs code :) Maybe we can do the
same with Darcsden.

Accepted.
History
Date User Action Args
2017-10-02 17:28:34bfcreate
2017-10-02 17:31:22bfsetstatus: needs-screening -> needs-review
2017-10-09 15:08:05ghsetstatus: needs-review -> accepted
messages: + msg19711