Patch 1608: refactor tentativelyMergePatches_ (6 patches) - Darcs bug tracker

Title	refactor tentativelyMergePatches_ (6 patches)
Superseder		Nosy List	bfrk
Related Issues
Status	accepted	Assigned To
Milestone

Created on 2017-10-03.17:29:54 by bfrk, last changed 2017-10-09.15:52:08 by gh.

Files
File name	Status	Uploaded	Type	Edit	Remove
moved-makechanges-from-d_r_hashed-to-d_r_merge.dpatch		bfrk, 2017-10-03.17:29:53	application/x-darcs-patch

See mailing list archives for discussion on individual patches.

Messages
msg19692 (view)	Author: bfrk	Date: 2017-10-03.17:29:53
The result is functionally identical but is now easier to read and understand and also more efficient (with --reorder-patches). Attachments moved-makechanges-from-d_r_hashed-to-d_r_merge.dpatch
msg19714 (view)	Author: gh	Date: 2017-10-09.15:52:07
Everything looks correct, except the reorder code which I have trouble to go through every step in my available time, but for this code I'm going to trust the (passing) shell test. Note that after this bundle, tentativelyReplacePatches is no longer used outside of src/Darcs/Repository/Hashed.hs . Accepted.

History
Date	User	Action	Args
2017-10-03 17:29:54	bfrk	create
2017-10-03 19:04:05	bfrk	set	status: needs-screening -> needs-review
2017-10-09 15:52:08	gh	set	status: needs-review -> accepted messages: + msg19714