darcs

Patch 1614 UI display of named patches / explicit dependencies

Title UI display of named patches / explicit dependencies
Superseder Nosy List bf
Related Issues
Status accepted Assigned To
Milestone

Created on 2017-10-10.10:43:26 by bf, last changed 2017-10-28.16:08:12 by gh.

Files
File name Status Uploaded Type Edit Remove
moved-shownamedprefix-from-d_p_show-to-d_p_named.dpatch bf, 2017-10-10.10:43:25 application/x-darcs-patch
See mailing list archives for discussion on individual patches.
Messages
msg19719 (view) Author: bf Date: 2017-10-10.10:43:25
Some of these patches may be controversial. Tell me what you think.

6 patches for repository bf@hub.darcs.net:darcs-current:

patch 154d95ccb23ea82ed4d98501629954823d559922
Author: Ben Franksen <ben.franksen@online.de>
Date:   Thu Oct  5 08:03:21 CEST 2017
  * moved showNamedPrefix from D.P.Show to D.P.Named

patch 7b33ae71b0411ef081b9d7922b3f01cca09b2d9f
Author: Ben Franksen <ben.franksen@online.de>
Date:   Thu Oct  5 16:51:00 CEST 2017
  * improved UI display of named patches
  
  Previously we used the same format to display the PatchInfo as for storage
  (i.e. showPatchInfo), and similarly for the PatchInfos of explicit
  dependencies. This could be seen by hitting 'v' when using 'darcs log' in
  interactive mode. We now use showPatchInfoUI when we show the
PatchInfo of a
  patch for display. Explicit dependencies are displayed less verbosely but
  still so that they can be identified easily:
  
  Explicit dependencies:
    patch <hash>
      * <patch name>
    patch <hash>
      * <patch name>
    ...

patch f5952fad159ad69ac8c734acad0da084d071136a
Author: Ben Franksen <benjamin.franksen@helmholtz-berlin.de>
Date:   Thu Oct  5 17:12:55 CEST 2017
  * yes, you should call showPatchInfo here!

patch 3a0da988b52bba2140ae9b03da95e60c934080f4
Author: Ben Franksen <benjamin.franksen@helmholtz-berlin.de>
Date:   Thu Oct  5 17:13:32 CEST 2017
  * use showPatchInfoUI, not showPatchInfo, for display

patch dcc337b03e38afbad2cf37e3120b642ea140157a
Author: Ben Franksen <benjamin.franksen@helmholtz-berlin.de>
Date:   Fri Oct  6 15:59:06 CEST 2017
  * make showPatchInfo more similar to showPatch
  
  It now takes a ShowPatchFor as first argument and showPatchInfoUI has been
  renamed to displayPatchInfo.

patch 33a95e78ebc810e0e959e1c7f9b1f3f867a5e2fd
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sat Oct  7 11:02:48 CEST 2017
  * fix: log --machine-readable should use showPatch ForStorage
  
  At least this is what the tests (ask_deps.sh, look_for_moves.sh) seem to
  expect. These tests were broken by
  
    patch 7b33ae71b0411ef081b9d7922b3f01cca09b2d9f
      * improved UI display of named patches
Attachments
msg19735 (view) Author: gh Date: 2017-10-11.19:06:12
I haven't looked in detail, but I believe the only patch that changes
some output is "improved UI display of named patches", and it is only
for patches with explicit dependencies, when we look at them with p or v
during "darcs log". It does not seem controversial to me, and the new
output format is much better (patch hash for unambiguous lookup and
patch name for fast human understanding).

So I'm screening this bundle.
msg19785 (view) Author: ganesh Date: 2017-10-26.20:24:46
Haven't looked at this in detail, but I'm very happy to see a split 
between the display and serialization formats.
msg19787 (view) Author: bf Date: 2017-10-26.21:10:17
Yeah, the separation is pretty much in line with what I did for prim
patches a while ago. I used similar names (display vs. show) to make the
connection clear.
msg19796 (view) Author: gh Date: 2017-10-28.16:08:12
After further examination I'm convinced we can accept this bundle.
History
Date User Action Args
2017-10-10 10:43:26bfcreate
2017-10-11 19:06:12ghsetstatus: needs-screening -> needs-review
messages: + msg19735
2017-10-26 20:24:47ganeshsetmessages: + msg19785
2017-10-26 21:10:17bfsetmessages: + msg19787
2017-10-28 16:08:12ghsetstatus: needs-review -> accepted
messages: + msg19796