Patch 1621 further improvements to command completion (4 patches)

Title further improvements to command completion (4 patches)
Superseder Nosy List bf
Related Issues
Status accepted Assigned To

Created on 2017-10-16.06:25:59 by bf, last changed 2018-02-07.22:41:33 by gh.

File name Status Uploaded Type Edit Remove
fixed-tests_disable_sh_-filter-out-descriptions-from-__list_options.dpatch bf, 2017-10-16.07:06:48 application/x-darcs-patch
further-improvements-of-zsh-completion-script.dpatch bf, 2017-10-16.06:25:58 application/x-darcs-patch
See mailing list archives for discussion on individual patches.
msg19751 (view) Author: bf Date: 2017-10-16.06:25:58
4 patches for repository bf@hub.darcs.net:darcs-current:

patch 71d1950a99d5c8af7ddb9091e5a47fd11d246e87
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sat Apr 22 02:27:07 CEST 2017
  * further improvements of zsh completion script
  - split --list-options output on line ending, rather than any white space
  - use _describe to display options together with help text,
    converting the first ';' to a ':'
  - added comments to explain the zsh expansion fu

patch 6331f8871cbba24adab86b197f3f67ed4cb62361
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sat Apr 22 02:21:47 CEST 2017
  * print "optionname;description" pairs with --list-options
  As discussed on the mailing list, this allows shell completion to display
  the descriptions alongside the options when chosing from a menu. For
  that do not support this, the completion script should just drop
  from the semicolon up to the end of the line.

patch 078f43545361e26d7423572f7b2cc67edf44badd
Author: Ben Franksen <ben.franksen@online.de>
Date:   Wed Aug 16 01:34:27 CEST 2017
  * improve file completion
  - add modifiedFileArgs and use it for amend, record, revert, whatsnew
  - rebase log doesn't currently support file arguments so use noArgs
  - list only files that are not yet given as command line arguments
  - use readUnrecordedFiltered from D.R.State which is more efficient
    since it can use the index

patch d0733230684205b03997bbf5d8cbd247cce5cae4
Author: Ben Franksen <ben.franksen@online.de>
Date:   Mon Oct 16 08:28:25 CEST 2017
  * bash completion: ignore everything after (including) semicolon
  In bash there is no way to display help for an option along with the
  itself, so the best we can do is to ignore the help text.
msg19755 (view) Author: bf Date: 2017-10-16.07:06:48
Added a second bundle that adapts tests/disable.sh such as to filter out
everything after semicolon when calling darcs with --list-options.
msg19846 (view) Author: gh Date: 2018-02-07.22:41:33
Seems good, accepted!

Note for people who want to test this bundle on a Linux machine that
also has an older darcs package installed (be it Debian, Ubuntu, etc.),
overwrite the file /usr/share/bash-completion/completions/darcs with
./contrib/darcs_completion from the repository.
Date User Action Args
2017-10-16 06:25:59bfcreate
2017-10-16 07:06:48bfsetfiles: + fixed-tests_disable_sh_-filter-out-descriptions-from-__list_options.dpatch
messages: + msg19755
2017-10-29 19:17:22ghsetstatus: needs-screening -> needs-review
2018-02-07 22:41:33ghsetstatus: needs-review -> accepted
messages: + msg19846