Patch 1638: Resolve issue2536: mask out internal matchers in `show files` routing logic - Darcs bug tracker

Title	Resolve issue2536: mask out internal matchers in `show files` routing logic
Superseder		Nosy List	ganesh, gpiero
Related Issues	"darcs show files" does not work in a repository with suspended patches, show files --no-files: can't mix match and pending flags View: 2501, 2536
Status	accepted	Assigned To
Milestone

Created on 2018-01-29.19:37:34 by gpiero, last changed 2018-03-23.14:03:16 by gh.

Files
File name	Status	Uploaded	Type	Edit	Remove
resolve-issue2536_-mask-out-internal-matchers-in-_show-files_-routing-logic.dpatch		gpiero, 2018-01-29.19:37:34	application/octet-stream

See mailing list archives for discussion on individual patches.

Messages
msg19832 (view)	Author: gpiero	Date: 2018-01-29.19:37:34
Just saw that issue2536 is a duplicate of issue2501. Given Ganesh's comment on issue2501, I'd say the attached patch would probably be rejected. Anyway, I think it could be temporary adopted while waiting for a better fix. 2 patches for repository http://darcs.net/screened: patch 92a33eb6558f1d0d2d363bd0b2411a50280fc31d Author: Gian Piero Carrubba <gpiero@rm-rf.it> Date: Mon Jan 29 09:05:56 CET 2018 * Resolve issue2536: mask out internal matchers in `show files` routing logic Avoid croaking out when an user issues a `show files` without matching options when a rebase is in progress. patch 03c49a7741904ca55fb5247cd6fa4ec4c1a1da20 Author: Gian Piero Carrubba <gpiero@rm-rf.it> Date: Mon Jan 29 18:07:22 CET 2018 * t/show_files: add tests checking 'show files' with a rebase in progress Attachments resolve-issue2536_-mask-out-internal-matchers-in-_show-files_-routing-logic.dpatch
msg19974 (view)	Author: gh	Date: 2018-03-15.19:17:32
A shell test would be nice in any case!
msg20001 (view)	Author: gh	Date: 2018-03-23.14:03:15
I.. do not know how I missed the shell test that you provided, Gian Piero! Accepted.

History
Date	User	Action	Args
2018-01-29 19:37:34	gpiero	create
2018-02-07 21:40:16	gh	set	status: needs-screening -> needs-review
2018-03-15 19:17:33	gh	set	nosy: + ganesh messages: + msg19974
2018-03-23 14:03:16	gh	set	status: needs-review -> accepted messages: + msg20001