Patch 1640: harness: simplify the defaults file (and two more) - Darcs bug tracker

Title	harness: simplify the defaults file (and two more)
Superseder		Nosy List	bfrk
Related Issues
Status	accepted	Assigned To
Milestone

Created on 2018-02-08.00:44:57 by bfrk, last changed 2018-03-26.15:04:36 by gh.

Files
File name	Status	Uploaded	Type	Edit	Remove
harness_-simplify-the-defaults-file.dpatch		bfrk, 2018-02-08.00:44:56	application/x-darcs-patch
remove-pragma-parsing-code-from-the-test-harness.dpatch		bfrk, 2018-03-24.11:03:33	application/x-darcs-patch
remove-pragma-parsing-code-from-the-test-harness.dpatch		bfrk, 2018-03-25.13:57:07	application/x-darcs-patch

See mailing list archives for discussion on individual patches.

Messages
msg19855 (view)	Author: bfrk	Date: 2018-02-08.00:44:56
3 patches for repository http://darcs.net/screened: Author: Ben Franksen <ben.franksen@online.de> Date: Sun Oct 29 22:54:05 CET 2017 * harness: simplify the defaults file Author: Ben Franksen <ben.franksen@online.de> Date: Sun Oct 29 22:56:07 CET 2017 * tests: removed unneeded removals of test repos Author: Ben Franksen <ben.franksen@online.de> Date: Sun Oct 29 23:02:40 CET 2017 * tests: clean up darcs format testing Removed the "#pragma repo-format..." lines as they seem useless. Replace manual tests for the repo format with calls to skip-format, where applicable. Removed restriction to darcs-1 or darcs-2 format where possible. Attachments harness_-simplify-the-defaults-file.dpatch
msg19904 (view)	Author: bfrk	Date: 2018-02-18.22:52:02
I am screening this now.
msg19970 (view)	Author: gh	Date: 2018-03-14.15:55:34
You probably also want to also remove the test harness code that handles these #pragma annotations (in harness/test.hs).
msg20012 (view)	Author: bfrk	Date: 2018-03-24.10:45:39
Attached a bundle with a follow-up patch, see below. I guess I should push this patch to screened because the rest is already in screened. Should I? patch e3efdc940abf1388459555a7184ec5810b5fe000 Author: Ben Franksen <ben.franksen@online.de> Date: Sat Mar 24 11:38:25 CET 2018 Attachments remove-pragma-parsing-code-from-the-test-harness.dpatch
msg20013 (view)	Author: bfrk	Date: 2018-03-24.10:49:34
Don't screen it, I made a mistake. Will re-send.
msg20014 (view)	Author: bfrk	Date: 2018-03-24.11:03:33
Here is a fixed version. 1 patch for repository http://darcs.net/screened: patch 6a9ca1a74fe49e9d9e1891ceca98d5ea2c07d02b Author: Ben Franksen <ben.franksen@online.de> Date: Sat Mar 24 11:38:25 CET 2018 * remove pragma parsing code from the test harness Attachments remove-pragma-parsing-code-from-the-test-harness.dpatch
msg20026 (view)	Author: bfrk	Date: 2018-03-25.12:11:09
Don't screen, I made another mistake that broke the network tests.
msg20031 (view)	Author: bfrk	Date: 2018-03-25.13:57:07
Here is the fixed follow-up patch. Also added a second patch which was motivated by the small simplification I made before (and that broke the network tests, now done correctly). patch 6b75b51f564af44fcb0310f1d937ace049fb09c3 Author: Ben Franksen <ben.franksen@online.de> Date: Sun Mar 25 14:37:13 CEST 2018 * shell/network tests: print only the basename of the test file Attachments remove-pragma-parsing-code-from-the-test-harness.dpatch
msg20040 (view)	Author: gh	Date: 2018-03-26.15:04:36
I could run the whole test suite just fine, so I'm accepting the whole set of patches. Thanks!

History
Date	User	Action	Args
2018-02-08 00:44:57	bfrk	create
2018-02-18 22:52:02	bfrk	set	messages: + msg19904
2018-02-18 23:25:04	bfrk	set	status: needs-screening -> needs-review
2018-03-14 15:55:34	gh	set	messages: + msg19970
2018-03-24 10:45:39	bfrk	set	files: + remove-pragma-parsing-code-from-the-test-harness.dpatch messages: + msg20012
2018-03-24 10:49:34	bfrk	set	messages: + msg20013
2018-03-24 11:02:52	bfrk	set	files: - remove-pragma-parsing-code-from-the-test-harness.dpatch
2018-03-24 11:03:33	bfrk	set	files: + remove-pragma-parsing-code-from-the-test-harness.dpatch messages: + msg20014
2018-03-25 12:11:09	bfrk	set	messages: + msg20026
2018-03-25 13:57:07	bfrk	set	files: + remove-pragma-parsing-code-from-the-test-harness.dpatch messages: + msg20031
2018-03-26 15:04:36	gh	set	status: needs-review -> accepted messages: + msg20040